Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 2.3.0 #1146

Merged
merged 1 commit into from Apr 28, 2021
Merged

Bump version to 2.3.0 #1146

merged 1 commit into from Apr 28, 2021

Conversation

bquorning
Copy link
Collaborator


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning requested review from pirj and Darhazer April 28, 2021 08:44
@bquorning bquorning marked this pull request as ready for review April 28, 2021 08:44
@@ -1,5 +1,5 @@
name: rubocop-rspec
title: RuboCop RSpec
version: master
version: '2.3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that you know whether it should include the '.0' at the end or not ;)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how we usually do it. I don't know more than that 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Only major and minor versions should be specified. Patch version is not required.
doc-version

@bquorning bquorning merged commit db9b566 into master Apr 28, 2021
@bquorning bquorning deleted the release branch April 28, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants