Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircleCI badge for new repo URL #1141

Merged
merged 1 commit into from Apr 17, 2021
Merged

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Apr 17, 2021

Badge and link are now dead as the GitHub repo URL has been changed from rubocop-hq to rubocop. CircleCI does not look like supporting redirecting from the old one to the current one.

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [n/a] Added tests.
  • Updated documentation.
  • [n/a] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • [n/a] Added the new cop to config/default.yml.
  • [n/a] The cop is configured as Enabled: pending in config/default.yml.
  • [n/a] The cop documents examples of good and bad code.
  • [n/a] The tests assert both that bad code is reported and that good code is not reported.
  • [n/a] Set VersionAdded in default/config.yml to the next minor version.

If you have modified an existing cop's configuration options:

  • [n/a] Set VersionChanged in config/default.yml to the next major version.

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@pirj pirj merged commit 781a046 into rubocop:master Apr 17, 2021
@pirj
Copy link
Member

pirj commented Apr 17, 2021

Thank you!

@tnir tnir deleted the circleci-badge branch April 19, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants