From 128e0a076acbe8f070e6e40600493e1ba720f3d7 Mon Sep 17 00:00:00 2001 From: Andrew Konchin Date: Wed, 1 Jul 2020 21:50:12 +0300 Subject: [PATCH] Refactor. Remove excessive call of example_group?(node) --- lib/rubocop/cop/rspec/nested_groups.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/rubocop/cop/rspec/nested_groups.rb b/lib/rubocop/cop/rspec/nested_groups.rb index cda5b5223..2193d0720 100644 --- a/lib/rubocop/cop/rspec/nested_groups.rb +++ b/lib/rubocop/cop/rspec/nested_groups.rb @@ -110,9 +110,10 @@ def on_top_level_describe(node, _args) private def find_nested_example_groups(node, nesting: 1, &block) - yield node, nesting if example_group?(node) && nesting > max_nesting + example_group = example_group?(node) + yield node, nesting if example_group && nesting > max_nesting - next_nesting = example_group?(node) ? nesting + 1 : nesting + next_nesting = example_group ? nesting + 1 : nesting node.each_child_node do |child| find_nested_example_groups(child, nesting: next_nesting, &block)