-
-
Notifications
You must be signed in to change notification settings - Fork 269
/
metadata_style.rb
202 lines (172 loc) · 5.6 KB
/
metadata_style.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
# frozen_string_literal: true
module RuboCop
module Cop
module RSpec
# Use consistent metadata style.
#
# This cop does not support autocorrection in the case of
# `EnforcedStyle: hash` where the trailing metadata type is ambiguous.
# (e.g. `describe 'Something', :a, b`)
#
# @example EnforcedStyle: symbol (default)
# # bad
# describe 'Something', a: true
#
# # good
# describe 'Something', :a
#
# @example EnforcedStyle: hash
# # bad
# describe 'Something', :a
#
# # good
# describe 'Something', a: true
class MetadataStyle < Base # rubocop:disable Metrics/ClassLength
extend AutoCorrector
include ConfigurableEnforcedStyle
include Metadata
include RangeHelp
# @!method extract_metadata_hash(node)
def_node_matcher :extract_metadata_hash, <<~PATTERN
(send _ _ _ ... $hash)
PATTERN
# @!method match_boolean_metadata_pair?(node)
def_node_matcher :match_boolean_metadata_pair?, <<~PATTERN
(pair sym true)
PATTERN
# @!method match_ambiguous_trailing_metadata?(node)
def_node_matcher :match_ambiguous_trailing_metadata?, <<~PATTERN
(send _ _ _ ... !{hash sym})
PATTERN
def on_metadata(symbols, hash)
# RSpec example groups accept two string arguments. In such a case,
# the rspec_metadata matcher will interpret the second string
# argument as a metadata symbol.
symbols.shift if symbols.first&.str_type?
symbols.each do |symbol|
on_metadata_symbol(symbol)
end
return unless hash
hash.pairs.each do |pair|
on_metadata_pair(pair)
end
end
private
def autocorrect_pair(corrector, node)
remove_pair(corrector, node)
insert_symbol(corrector, node)
end
def autocorrect_symbol(corrector, node)
return if match_ambiguous_trailing_metadata?(node.parent)
remove_symbol(corrector, node)
insert_pair(corrector, node)
end
def bad_metadata_pair?(node)
style == :symbol && match_boolean_metadata_pair?(node)
end
def bad_metadata_symbol?(_node)
style == :hash
end
def format_symbol_to_pair_source(node)
"#{node.value}: true"
end
def insert_pair(corrector, node)
hash_node = extract_metadata_hash(node.parent)
if hash_node.nil?
insert_pair_as_last_argument(corrector, node)
elsif hash_node.pairs.any?
insert_pair_to_non_empty_hash_metadata(corrector, node, hash_node)
else
insert_pair_to_empty_hash_metadata(corrector, node, hash_node)
end
end
def insert_pair_as_last_argument(corrector, node)
corrector.insert_before(
node.parent.location.end || node.parent.source_range.with(
begin_pos: node.parent.source_range.end_pos
),
", #{format_symbol_to_pair_source(node)}"
)
end
def insert_pair_to_empty_hash_metadata(corrector, node, hash_node)
corrector.insert_after(
hash_node.location.begin,
" #{format_symbol_to_pair_source(node)} "
)
end
def insert_pair_to_non_empty_hash_metadata(corrector, node, hash_node)
corrector.insert_after(
hash_node.children.last,
", #{format_symbol_to_pair_source(node)}"
)
end
def insert_symbol(corrector, node)
corrector.insert_after(
node.parent.left_sibling,
", #{node.key.value.inspect}"
)
end
def message_for_style
format(
'Use %<style>s style for metadata.',
style: style
)
end
def on_metadata_pair(node)
return unless bad_metadata_pair?(node)
add_offense(node, message: message_for_style) do |corrector|
autocorrect_pair(corrector, node)
end
end
def on_metadata_symbol(node)
return unless bad_metadata_symbol?(node)
add_offense(node, message: message_for_style) do |corrector|
autocorrect_symbol(corrector, node)
end
end
def remove_pair(corrector, node)
if !node.parent.braces? || node.left_siblings.any?
remove_pair_following(corrector, node)
elsif node.right_siblings.any?
remove_pair_preceding(corrector, node)
else
corrector.remove(node)
end
end
def remove_pair_following(corrector, node)
corrector.remove(
range_with_surrounding_comma(
range_with_surrounding_space(
node.source_range,
side: :left
),
:left
)
)
end
def remove_pair_preceding(corrector, node)
corrector.remove(
range_with_surrounding_space(
range_with_surrounding_comma(
node.source_range,
:right
),
side: :right
)
)
end
def remove_symbol(corrector, node)
corrector.remove(
range_with_surrounding_comma(
range_with_surrounding_space(
node.source_range,
side: :left
),
:left
)
)
end
end
end
end
end