-
-
Notifications
You must be signed in to change notification settings - Fork 270
/
leading_subject_spec.rb
284 lines (229 loc) · 6.7 KB
/
leading_subject_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
subject(:cop) { described_class.new }
it 'checks subject below let' do
expect_offense(<<-RUBY)
RSpec.describe User do
let(:params) { foo }
subject { described_class.new }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `let` declarations.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
subject { described_class.new }
let(:params) { foo }
end
RUBY
end
it 'checks subject below let!' do
expect_offense(<<-RUBY)
RSpec.describe User do
let!(:params) { foo }
subject { described_class.new }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `let!` declarations.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
subject { described_class.new }
let!(:params) { foo }
end
RUBY
end
it 'checks subject below let with proc argument' do
expect_offense(<<-RUBY)
RSpec.describe User do
let(:user, &args[:build_user])
subject { described_class.new }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `let` declarations.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
subject { described_class.new }
let(:user, &args[:build_user])
end
RUBY
end
it 'approves of subject above let' do
expect_no_offenses(<<-RUBY)
RSpec.describe User do
subject { described_class.new }
let(:params) { foo }
context 'blah' do
end
end
RUBY
end
it 'handles subjects in contexts' do
expect_no_offenses(<<-RUBY)
RSpec.describe User do
let(:params) { foo }
context "when something happens" do
subject { described_class.new }
end
end
RUBY
end
it 'handles subjects in tests' do
expect_no_offenses(<<-RUBY)
RSpec.describe User do
# This shouldn't really ever happen in a sane codebase but I still
# want to avoid false positives
it "doesn't mind me calling a method called subject in the test" do
let(foo)
subject { bar }
end
end
RUBY
end
it 'checks subject below hook' do
expect_offense(<<-RUBY)
RSpec.describe User do
before { allow(Foo).to receive(:bar) }
subject { described_class.new }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `before` declarations.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
subject { described_class.new }
before { allow(Foo).to receive(:bar) }
end
RUBY
end
it 'checks subject below example' do
expect_offense(<<-RUBY)
RSpec.describe User do
it { is_expected.to be_present }
subject { described_class.new }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `it` declarations.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
subject { described_class.new }
it { is_expected.to be_present }
end
RUBY
end
it 'checks also when subject is below a non-offending node' do
expect_offense(<<~RUBY)
RSpec.describe do
def helper_method
end
it { is_expected.to be_present }
subject { described_class.new }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `it` declarations.
end
RUBY
expect_correction(<<~RUBY)
RSpec.describe do
def helper_method
end
subject { described_class.new }
it { is_expected.to be_present }
end
RUBY
end
it 'flags subject below example group' do
expect_offense(<<-RUBY)
RSpec.describe User do
describe do
it { is_expected.to be_present }
end
subject { described_class.new }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `describe` declarations.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
subject { described_class.new }
describe do
it { is_expected.to be_present }
end
end
RUBY
end
it 'flags subject below shared example group' do
expect_offense(<<-RUBY)
RSpec.describe User do
shared_examples_for 'used later' do
it { is_expected.to be_present }
end
subject { described_class.new }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `shared_examples_for` declarations.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
subject { described_class.new }
shared_examples_for 'used later' do
it { is_expected.to be_present }
end
end
RUBY
end
it 'flags subject below include' do
expect_offense(<<-RUBY)
RSpec.describe User do
it_behaves_like 'a good citizen'
subject { described_class.new }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `it_behaves_like` declarations.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
subject { described_class.new }
it_behaves_like 'a good citizen'
end
RUBY
end
it 'flags subject below include with a block' do
expect_offense(<<-RUBY)
RSpec.describe User do
it_behaves_like 'a good citizen' do
let(:used_in_shared_examples) { 'something' }
end
subject { described_class.new }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `it_behaves_like` declarations.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
subject { described_class.new }
it_behaves_like 'a good citizen' do
let(:used_in_shared_examples) { 'something' }
end
end
RUBY
end
it 'flags subject below include with a blockpass' do
expect_offense(<<-RUBY)
RSpec.describe User do
block = ->{ }
it_behaves_like 'a good citizen', &block
subject { described_class.new }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `it_behaves_like` declarations.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
block = ->{ }
subject { described_class.new }
it_behaves_like 'a good citizen', &block
end
RUBY
end
it 'ignores subject nested inside a block' do
expect_no_offenses(<<-RUBY)
RSpec.describe User do
let(:foo) { 'bar' }
it_behaves_like 'a good citizen' do
subject { described_class.new }
end
end
RUBY
end
end