/
let_before_examples_spec.rb
156 lines (126 loc) · 3.35 KB
/
let_before_examples_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::RSpec::LetBeforeExamples do
subject(:cop) { described_class.new }
it 'flags `let` after `it`' do
expect_offense(<<-RUBY)
RSpec.describe User do
it { is_expected.to be_after_let }
let(:foo) { bar }
^^^^^^^^^^^^^^^^^ Move `let` before the examples in the group.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
let(:foo) { bar }
it { is_expected.to be_after_let }
end
RUBY
end
it 'flags `let` after `context`' do
expect_offense(<<-RUBY)
RSpec.describe User do
context 'a context' do
it { is_expected.to be_after_let }
end
let(:foo) { bar }
^^^^^^^^^^^^^^^^^ Move `let` before the examples in the group.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
let(:foo) { bar }
context 'a context' do
it { is_expected.to be_after_let }
end
end
RUBY
end
it 'flags `let` after `include_examples`' do
expect_offense(<<-RUBY)
RSpec.describe User do
include_examples('should be after let')
let(:foo) { bar }
^^^^^^^^^^^^^^^^^ Move `let` before the examples in the group.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
let(:foo) { bar }
include_examples('should be after let')
end
RUBY
end
it 'flags `let` with proc argument' do
expect_offense(<<-RUBY)
RSpec.describe User do
include_examples('should be after let')
let(:user, &args[:build_user])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Move `let` before the examples in the group.
end
RUBY
expect_correction(<<-RUBY)
RSpec.describe User do
let(:user, &args[:build_user])
include_examples('should be after let')
end
RUBY
end
it 'does not flag `let` before the examples' do
expect_no_offenses(<<-RUBY)
RSpec.describe User do
let(:foo) { bar }
it { is_expected.to be_after_let }
context 'a context' do
it { is_expected.to work }
end
include_examples('everything is fine')
end
RUBY
end
it 'does not flag `let` in a nested context' do
expect_no_offenses(<<-RUBY)
RSpec.describe User do
let(:foo) { bar }
context 'something else' do
let(:foo) { baz }
it { is_expected.to work }
end
include_examples('everything is fine')
end
RUBY
end
it 'allows inclusion of context before `let`' do
expect_no_offenses(<<-RUBY)
RSpec.describe User do
include_context 'special user'
let(:foo) { bar }
end
RUBY
end
it 'ignores single-line example blocks' do
expect_no_offenses(<<-RUBY)
RSpec.describe User do
include_examples 'special user' do
let(:foo) { bar }
end
end
RUBY
end
bad_code = <<-RUBY
RSpec.describe User do
include_examples('should be after let')
let(:foo) { (<<-SOURCE) }
some long text here
SOURCE
end
RUBY
good_code = <<-RUBY
RSpec.describe User do
let(:foo) { (<<-SOURCE) }
some long text here
SOURCE
include_examples('should be after let')
end
RUBY
include_examples 'autocorrect', bad_code, good_code
end