-
-
Notifications
You must be signed in to change notification settings - Fork 271
/
repeated_example_group_body_spec.rb
334 lines (279 loc) · 8.68 KB
/
repeated_example_group_body_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::RSpec::RepeatedExampleGroupBody do
it 'registers an offense for repeated describe body' do
expect_offense(<<-RUBY)
describe 'doing x' do
^^^^^^^^^^^^^^^^^^^^^ Repeated describe block body on line(s) [5]
it { cool_predicate_method }
end
describe 'doing y' do
^^^^^^^^^^^^^^^^^^^^^ Repeated describe block body on line(s) [1]
it { cool_predicate_method }
end
RUBY
end
it 'registers an offense for repeated context body' do
expect_offense(<<-RUBY)
context 'when awesome case' do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Repeated context block body on line(s) [5]
it { cool_predicate_method }
end
context 'when another awesome case' do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Repeated context block body on line(s) [1]
it { cool_predicate_method }
end
RUBY
end
it 'registers an offense for several repeated context body' do
expect_offense(<<-RUBY)
context 'when usual case' do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Repeated context block body on line(s) [5, 9]
it { cool_predicate_method }
end
context 'when awesome case' do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Repeated context block body on line(s) [1, 9]
it { cool_predicate_method }
end
context 'when another awesome case' do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Repeated context block body on line(s) [1, 5]
it { cool_predicate_method }
end
RUBY
end
it 'does not register offense for different block body implementation' do
expect_no_offenses(<<-RUBY)
context 'when awesome case' do
it { cool_predicate_method }
end
context 'when another awesome case' do
it { another_predicate_method }
end
RUBY
end
it 'does not register offense if metadata is different' do
expect_no_offenses(<<-RUBY)
describe 'doing x' do
it { cool_predicate_method }
end
describe 'doing x', :request do
it { cool_predicate_method }
end
RUBY
end
it 'does not register offense if module arg is different' do
expect_no_offenses(<<-RUBY)
describe CSV::Row do
it { is_expected.to respond_to :headers }
end
describe CSV::Table do
it { is_expected.to respond_to :headers }
end
RUBY
end
it 'does not register offense when module arg namespace is different' do
expect_no_offenses(<<-RUBY)
describe CSV::Parser do
it { expect(described_class).to respond_to(:parse) }
end
describe URI::Parser do
it { expect(described_class).to respond_to(:parse) }
end
RUBY
end
it 'registers an offense for when module arg and namespace are identical' do
expect_offense(<<-RUBY)
context Net::HTTP do
^^^^^^^^^^^^^^^^^^^^ Repeated context block body on line(s) [5]
it { expect(described_class).to respond_to :start }
end
context Net::HTTP do
^^^^^^^^^^^^^^^^^^^^ Repeated context block body on line(s) [1]
it { expect(described_class).to respond_to :start }
end
RUBY
end
it 'does not register offense with several docstring' do
expect_no_offenses(<<-RUBY)
describe 'doing x', :json, 'request' do
it { cool_predicate_method }
end
describe 'doing x', 'request' do
it { cool_predicate_method }
end
RUBY
end
it 'registers offense for different groups' do
expect_offense(<<-RUBY)
describe 'doing x' do
^^^^^^^^^^^^^^^^^^^^^ Repeated describe block body on line(s) [5]
it { cool_predicate_method }
end
context 'when a is true' do
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Repeated context block body on line(s) [1]
it { cool_predicate_method }
end
RUBY
end
it 'does not register offense for example groups in different groups' do
expect_no_offenses(<<-RUBY)
describe 'A' do
describe '.b' do
context 'when this' do
it { do_something }
end
end
context 'when this' do
it { do_something }
end
end
RUBY
end
it 'registers offense only for RSPEC namespace example groups' do
expect_offense(<<-RUBY)
helpers.describe 'doing x' do
it { cool_predicate_method }
end
RSpec.describe 'doing x' do
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Repeated describe block body on line(s) [9]
it { cool_predicate_method }
end
context 'when a is true' do
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Repeated context block body on line(s) [5]
it { cool_predicate_method }
end
RUBY
end
it 'registers offense only for RSPEC namespace example groups in any order' do
expect_offense(<<-RUBY)
RSpec.describe 'doing x' do
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Repeated describe block body on line(s) [5]
it { cool_predicate_method }
end
context 'when a is true' do
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Repeated context block body on line(s) [1]
it { cool_predicate_method }
end
helpers.describe 'doing x' do
it { cool_predicate_method }
end
RUBY
end
it 'registers offense only for example group' do
expect_offense(<<-RUBY)
RSpec.describe 'A' do
stub_all_http_calls()
allowed_statuses = %i[open submitted approved].freeze
before { create(:admin) }
allowed_statuses = %i[open submitted approved].freeze
describe '#load' do
^^^^^^^^^^^^^^^^^^^ Repeated describe block body on line(s) [11]
it { cool_predicate_method }
end
describe '#load' do
^^^^^^^^^^^^^^^^^^^ Repeated describe block body on line(s) [7]
it { cool_predicate_method }
end
end
RUBY
end
it 'skips `skip` and `pending` statements' do
expect_no_offenses(<<-RUBY)
context 'rejected' do
skip
end
context 'processed' do
skip
end
context 'processed' do
pending
end
RUBY
end
it 'skips `skip` and `pending` statements with arguments' do
expect_no_offenses(<<-RUBY)
describe '#load' do
skip 'storage feature needed'
end
describe '#save' do
skip 'storage feature needed'
end
describe '#get_foo' do
pending 'foo feature is broken'
end
describe '#set_foo' do
pending 'foo feature is broken'
end
RUBY
end
it 'registers offense correctly if `skip` and `pending` have block' do
expect_offense(<<-RUBY)
describe '#load' do
^^^^^^^^^^^^^^^^^^^ Repeated describe block body on line(s) [5]
skip { cool_predicate_method }
end
describe '#save' do
^^^^^^^^^^^^^^^^^^^ Repeated describe block body on line(s) [1]
skip { cool_predicate_method }
end
describe '#get_foo' do
^^^^^^^^^^^^^^^^^^^^^^ Repeated describe block body on line(s) [13]
pending { cool_predicate_method }
end
describe '#set_foo' do
^^^^^^^^^^^^^^^^^^^^^^ Repeated describe block body on line(s) [9]
pending { cool_predicate_method }
end
RUBY
end
it 'registers offense correctly if example groups are separated' do
expect_offense(<<-RUBY)
describe 'repeated' do
^^^^^^^^^^^^^^^^^^^^^^ Repeated describe block body on line(s) [7]
it { is_expected.to be_truthy }
end
before { do_something }
describe 'this is repeated' do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Repeated describe block body on line(s) [1]
it { is_expected.to be_truthy }
end
RUBY
end
it 'does not register offense for same examples with different data' do
expect_no_offenses(<<-RUBY)
context 'when admin' do
let(:user) { admin }
it { is_expected.to be_truthy }
end
context 'when regular user' do
let(:user) { staff }
it { is_expected.to be_truthy }
end
RUBY
end
it 'does not register offense if no descriptions, but different body' do
expect_no_offenses(<<-RUBY)
context do
let(:preferences) { default_preferences }
it { is_expected.to eq false }
end
context do
let(:preferences) { %w[a] }
it { is_expected.to eq true }
end
RUBY
end
it 'registers offense no descriptions and similar body' do
expect_offense(<<-RUBY)
context do
^^^^^^^^^^ Repeated context block body on line(s) [7]
let(:preferences) { %w[a] }
it { is_expected.to eq true }
end
context do
^^^^^^^^^^ Repeated context block body on line(s) [1]
let(:preferences) { %w[a] }
it { is_expected.to eq true }
end
RUBY
end
end