-
-
Notifications
You must be signed in to change notification settings - Fork 269
/
leaky_constant_declaration_spec.rb
115 lines (104 loc) · 3.02 KB
/
leaky_constant_declaration_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::RSpec::LeakyConstantDeclaration do
describe 'constant assignment' do
it 'flags inside an example group' do
expect_offense(<<~RUBY)
describe SomeClass do
CONSTANT = "Accessible as ::CONSTANT".freeze
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Stub constant instead of declaring explicitly.
end
RUBY
end
it 'flags inside shared example group' do
expect_offense(<<~RUBY)
RSpec.shared_examples 'shared example' do
CONSTANT = "Accessible as ::CONSTANT".freeze
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Stub constant instead of declaring explicitly.
end
RUBY
end
it 'flags inside an example' do
expect_offense(<<~RUBY)
describe SomeClass do
specify do
CONSTANT = "Accessible as ::CONSTANT".freeze
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Stub constant instead of declaring explicitly.
end
end
RUBY
end
it 'ignores constant defined on the example group' do
expect_no_offenses(<<~RUBY)
describe SomeClass do
self::CONSTANT = "Accessible as self.class::CONSTANT".freeze
end
RUBY
end
it 'ignores outside of example/shared group' do
expect_no_offenses(<<~RUBY)
factory :some_class do
CONSTANT = "Accessible as ::CONSTANT".freeze
end
RUBY
end
end
describe 'class defined' do
it 'flags inside an example group' do
expect_offense(<<~RUBY)
describe SomeClass do
class DummyClass < described_class
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Stub class constant instead of declaring explicitly.
end
end
RUBY
end
it 'ignores anonymous classes' do
expect_no_offenses(<<~RUBY)
describe SomeClass do
let(:dummy_playbook) do
Class.new do
def method
end
end
end
end
RUBY
end
it 'ignores classes defined on the example group' do
expect_no_offenses(<<~RUBY)
describe SomeClass do
class self::DummyClass
end
end
RUBY
end
it 'flags namespaced class' do
expect_offense(<<~RUBY)
describe SomeClass do
class SomeModule::AnotherModule::DummyClass
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Stub class constant instead of declaring explicitly.
end
end
RUBY
end
end
describe 'module defined' do
it 'flags inside an example group' do
expect_offense(<<~RUBY)
describe SomeClass do
module DummyModule
^^^^^^^^^^^^^^^^^^ Stub module constant instead of declaring explicitly.
end
end
RUBY
end
it 'ignores modules defined on the example group' do
expect_no_offenses(<<~RUBY)
describe SomeClass do
module self::DummyModule
end
end
RUBY
end
end
end