-
-
Notifications
You must be signed in to change notification settings - Fork 269
/
return_from_stub_spec.rb
287 lines (250 loc) · 7.52 KB
/
return_from_stub_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
let(:cop_config) do
{ 'EnforcedStyle' => enforced_style }
end
context 'with EnforcedStyle `and_return`' do
let(:enforced_style) { 'and_return' }
it 'finds static values returned from block' do
expect_offense(<<-RUBY)
it do
allow(Foo).to receive(:bar) { 42 }
^ Use `and_return` for static values.
end
RUBY
expect_correction(<<-RUBY)
it do
allow(Foo).to receive(:bar).and_return(42)
end
RUBY
end
it 'finds empty values returned from block' do
expect_offense(<<-RUBY)
it do
allow(Foo).to receive(:bar) {}
^ Use `and_return` for static values.
end
RUBY
expect_correction(<<-RUBY)
it do
allow(Foo).to receive(:bar).and_return(nil)
end
RUBY
end
it 'finds array with only static values returned from block' do
expect_offense(<<-RUBY)
it do
allow(Foo).to receive(:bar) { [42, 43] }
^ Use `and_return` for static values.
end
RUBY
expect_correction(<<-RUBY)
it do
allow(Foo).to receive(:bar).and_return([42, 43])
end
RUBY
end
it 'finds hash with only static values returned from block' do
expect_offense(<<-RUBY)
it do
allow(Foo).to receive(:bar) { {a: 42, b: 43} }
^ Use `and_return` for static values.
end
RUBY
expect_correction(<<-RUBY)
it do
allow(Foo).to receive(:bar).and_return({a: 42, b: 43})
end
RUBY
end
it 'finds static values in a block when there are chained methods' do
expect_offense(<<-RUBY)
it do
allow(Question).to receive(:meaning).with(:universe) { 42 }
^ Use `and_return` for static values.
end
RUBY
expect_correction(<<-RUBY)
it do
allow(Question).to receive(:meaning).with(:universe).and_return(42)
end
RUBY
end
it 'finds constants returned from block' do
expect_offense(<<-RUBY)
it do
allow(Foo).to receive(:bar) { Life::MEANING }
^ Use `and_return` for static values.
end
RUBY
expect_correction(<<-RUBY)
it do
allow(Foo).to receive(:bar).and_return(Life::MEANING)
end
RUBY
end
it 'finds nested constants returned from block' do
expect_offense(<<-RUBY)
it do
allow(Foo).to receive(:bar) { {Life::MEANING => 42} }
^ Use `and_return` for static values.
end
RUBY
expect_correction(<<-RUBY)
it do
allow(Foo).to receive(:bar).and_return({Life::MEANING => 42})
end
RUBY
end
it 'ignores dynamic values returned from block' do
expect_no_offenses(<<-RUBY)
it do
allow(Foo).to receive(:bar) { baz }
end
RUBY
end
it 'ignores variables return from block' do
expect_no_offenses(<<-RUBY)
it do
$bar = 42
baz = 123
allow(Foo).to receive(:bar) { $bar }
allow(Foo).to receive(:baz) { baz }
end
RUBY
end
it 'ignores array with dynamic values returned from block' do
expect_no_offenses(<<-RUBY)
it do
allow(Foo).to receive(:bar) { [42, baz] }
end
RUBY
end
it 'ignores hash with dynamic values returned from block' do
expect_no_offenses(<<-RUBY)
it do
allow(Foo).to receive(:bar) { {a: 42, b: baz} }
end
RUBY
end
it 'ignores block returning string with interpolation' do
expect_no_offenses(<<-RUBY)
it do
bar = 42
allow(Foo).to receive(:bar) { "You called \#{bar}" }
end
RUBY
end
it 'finds concatenated strings with no variables' do
expect_offense(<<-RUBY)
it do
allow(Foo).to receive(:bar) do
^^ Use `and_return` for static values.
"You called" \
"me"
end
end
RUBY
expect_correction(<<-RUBY)
it do
allow(Foo).to receive(:bar).and_return("You called" \
"me")
end
RUBY
end
it 'ignores stubs without return value' do
expect_no_offenses(<<-RUBY)
it do
allow(Foo).to receive(:bar)
end
RUBY
end
it 'handles stubs in a method' do
expect_no_offenses(<<-RUBY)
def stub_foo
allow(Foo).to receive(:bar)
end
RUBY
end
end
context 'with EnforcedStyle `block`' do
let(:enforced_style) { 'block' }
it 'finds static values returned from method' do
expect_offense(<<-RUBY)
it do
allow(Foo).to receive(:bar).and_return(42)
^^^^^^^^^^ Use block for static values.
end
RUBY
end
it 'finds static values returned from chained method' do
expect_offense(<<-RUBY)
it do
allow(Foo).to receive(:bar).with(1).and_return(42)
^^^^^^^^^^ Use block for static values.
end
RUBY
end
it 'ignores dynamic values returned from method' do
expect_no_offenses(<<-RUBY)
it do
allow(Foo).to receive(:bar).and_return(baz)
end
RUBY
end
it 'ignores string with interpolation returned from method' do
expect_no_offenses(<<-RUBY)
it do
bar = 42
allow(Foo).to receive(:bar).and_return("You called \#{bar}")
end
RUBY
end
it 'ignores multiple values being returned from method' do
expect_no_offenses(<<-RUBY)
it do
allow(Foo).to receive(:bar).and_return(42, 43, 44)
end
RUBY
end
it 'finds hash with only static values returned from method' do
expect_offense(<<-RUBY)
allow(Foo).to receive(:bar).and_return({ foo: 42 })
^^^^^^^^^^ Use block for static values.
allow(Foo).to receive(:bar).and_return(foo: 42)
^^^^^^^^^^ Use block for static values.
allow(Foo).to receive(:bar).and_return(
^^^^^^^^^^ Use block for static values.
a: 42,
b: 43
)
RUBY
expect_correction(<<-RUBY) # Not perfect, but good enough.
allow(Foo).to receive(:bar) { { foo: 42 } }
allow(Foo).to receive(:bar) { { foo: 42 } }
allow(Foo).to receive(:bar) { { a: 42,
b: 43 } }
RUBY
end
it 'finds nil returned from method' do
expect_offense(<<-RUBY)
allow(Foo).to receive(:bar).and_return(nil)
^^^^^^^^^^ Use block for static values.
RUBY
expect_correction(<<-RUBY)
allow(Foo).to receive(:bar) { nil }
RUBY
end
it 'finds concatenated strings with no variables' do
expect_offense(<<-RUBY)
allow(Foo).to receive(:bar).and_return('You called ' \\
^^^^^^^^^^ Use block for static values.
'me')
RUBY
expect_correction(<<-RUBY)
allow(Foo).to receive(:bar) { 'You called ' \\
'me' }
RUBY
end
end
end