Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #763] Fix a false positive for Rails/RootPathnameMethods #768

Conversation

koic
Copy link
Member

@koic koic commented Sep 10, 2022

Fixes #763.

This PR fix a false positive for Rails/RootPathnameMethods when using Dir.glob. And marks unsafe for autocorrection because Dir's methods return string element, but Pathname's methods return Pathname element.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Fixes rubocop#763.

This PR fix a false positive for `Rails/RootPathnameMethods` when using `Dir.glob`.
And marks unsafe for autocorrection because `Dir`'s methods return string element,
but `Pathname`'s methods return `Pathname` element.
@koic koic merged commit 32daa2f into rubocop:master Sep 12, 2022
@koic koic deleted the fix_an_incorrect_autocorrect_for_rails_root_pathname_methods branch September 12, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.16 autocorrect of Rails/RootPathnameMethods is unsafe, i.e. breaking code
1 participant