Rails/ReflectionClassName false positive with Ruby 3.1 shorthand hashes

[shkm]

Expected behavior

RuboCop Rails should not raise an offence

Actual behavior

It does raise an offence :)

Steps to reproduce the problem

# frozen_string_literal: true

# Author
class Author < ApplicationRecord
  class_name = 'Book'
  has_many :books, dependent: :destroy, class_name:
end

rubocop app/models/author.rb
Inspecting 1 file
C

Offenses:

app/models/author.rb:6:41: C: Rails/ReflectionClassName: Use a string value for class_name.
  has_many :books, dependent: :destroy, class_name:
                                        ^^^^^^^^^^^

I've created a minimal example here: https://github.com/shkm/rubocop-rails-shorthand-hash-bug

RuboCop version

RuboCop Rails current master (0d0767d)

1.35.1 (using Parser 3.1.2.1, rubocop-ast 1.21.0, running on ruby 3.1.2 x86_64-linux)
  - rubocop-rails 2.15.2

This issue may be related to #106

[koic]

This is the Hash shorthand syntax introduced in Ruby 3.1. Please see the Style/HashSyntax documentation for more information in this case. Thank you.
https://docs.rubocop.org/rubocop/1.34/cops_style.html#enforcedshorthandsyntax-always-default

[shkm]

Hi @koic,

Indeed it's the shorthand syntax, but shouldn't rubocop-rails work with it? The complaint is coming from rubocop-rails, not rubocop. We have EnforcedShorthandSyntax set to true (default) and don't see any problems elsewhere; it's specifically on a has_many.

[koic]

Oops, You are right! This is a RuboCop Rails issue 🙇