Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #515] Fix an error for Rails/BulkChangeTable #516

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

koic
Copy link
Member

@koic koic commented Jul 1, 2021

Fixes #515
Follow up ruby/psych#487 and rails/rails@255b5ff

This PR fixes an error for Rails/BulkChangeTable when using Psych 4.0.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic force-pushed the fix_error_rails_bulk_change_table branch from 32d7443 to e4cf5b4 Compare July 1, 2021 11:11
Fixes rubocop#515
Follow up ruby/psych#487 and rails/rails@255b5ff

This PR fixes an error for `Rails/BulkChangeTable` when using Psych 4.0.
@koic koic force-pushed the fix_error_rails_bulk_change_table branch from e4cf5b4 to 97b6943 Compare July 1, 2021 11:46
@koic koic merged commit 37de74e into rubocop:master Jul 1, 2021
@koic koic deleted the fix_error_rails_bulk_change_table branch July 1, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails 6.1.4: An error occurred while Rails/BulkChangeTable cop was inspecting
1 participant