Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Release #47

Closed
bbatsov opened this issue Mar 14, 2019 · 6 comments
Closed

Initial Release #47

bbatsov opened this issue Mar 14, 2019 · 6 comments

Comments

@bbatsov
Copy link
Contributor

bbatsov commented Mar 14, 2019

I'm adding this ticket, as a place to track down what needs to be done for an initial release.

@koic just cut the very first release of rubocop-performance and I guess he'll now replicate the process here.

@koic, what remains to be done?

@koic
Copy link
Member

koic commented Mar 15, 2019

The main remaining tasks are:

  • Extract TargetRailsVersion.
  • Add documents.

Others are small tasks. I think that there is no work to be noted.

Among them, it may take a while to extract TargetRailsVersion.

@bbatsov
Copy link
Contributor Author

bbatsov commented Mar 15, 2019

Got it. Well, let's wrap the Performance cops removal first then, and tackle the rails stuff afterwards.

@koic
Copy link
Member

koic commented May 21, 2019

@bbatsov Sorry I made you wait. RuboCop Rails release schedule.

/Cc @toshimaru

I have made a rough preparation up to here.

On the other hand, the following is the work after extracting RuboCop Rails.

Extracting RailsTargetVersion is likely to take some time. Extracting the RailsTargetVersion is an internal implementation issue and will probably not affect users.

First of all, I'd like to extract RailsTargetVersion sometime after releasing RuboCop Rails.

@koic koic mentioned this issue May 21, 2019
8 tasks
@bbatsov
Copy link
Contributor Author

bbatsov commented May 21, 2019

First of all, I'd like to extract RailsTargetVersion sometime after releasing RuboCop Rails.

I agree. Keeping this in RuboCop itself is not a big deal for now.

#54 requires rubocop/rubocop#7048. Wait for the next RuboCop core (> 0.69.0) release.

Understood. I'll cut the new release ASAP.

@bbatsov
Copy link
Contributor Author

bbatsov commented May 21, 2019

The new release is out! I'm looking forward RuboCop Rails 2.0!

@koic koic closed this as completed in 0f33dbc May 21, 2019
koic added a commit that referenced this issue May 21, 2019
@koic
Copy link
Member

koic commented May 21, 2019

RuboCop Rails 2.0.0 has been released!
https://rubygems.org/gems/rubocop-rails/versions/2.0.0

koic added a commit to koic/rubocop that referenced this issue May 31, 2019
Fixes rubocop#5976.

This PR removes Rails department from RuboCop core.

- Remove Rails department cops
- Remove `-R/--rails` option from `rubocop` command

These were transferred to RuboCop Rails gem.
https://github.com/rubocop-hq/rubocop-rails

Some internal implementations of `TargetRailsVersion` remain. The final
goal in the near future is to extract `TargetRailsVersion`
implementation to RuboCop Rails from RuboCop core.
rubocop/rubocop-rails#47

This PR aims removing Rails cops and `rubocop -R /-rails` option that
affect RuboCop 0.72.0 users.

It may be better to merge this PR when we decide the next release
version is RuboCop 0.72.
bbatsov pushed a commit to rubocop/rubocop that referenced this issue Jun 2, 2019
Fixes #5976.

This PR removes Rails department from RuboCop core.

- Remove Rails department cops
- Remove `-R/--rails` option from `rubocop` command

These were transferred to RuboCop Rails gem.
https://github.com/rubocop-hq/rubocop-rails

Some internal implementations of `TargetRailsVersion` remain. The final
goal in the near future is to extract `TargetRailsVersion`
implementation to RuboCop Rails from RuboCop core.
rubocop/rubocop-rails#47

This PR aims removing Rails cops and `rubocop -R /-rails` option that
affect RuboCop 0.72.0 users.

It may be better to merge this PR when we decide the next release
version is RuboCop 0.72.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants