Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests on master are failing with latest rubocop #374

Closed
andyw8 opened this issue Oct 17, 2020 · 1 comment
Closed

Tests on master are failing with latest rubocop #374

andyw8 opened this issue Oct 17, 2020 · 1 comment

Comments

@andyw8
Copy link
Contributor

andyw8 commented Oct 17, 2020

On a fresh checkout there are many failures such as:

An error occurred while RSpec/FactoryBot/CreateList cop was inspecting /Users/andyw8/src/github.com/rubocop-hq/rubocop-rails/spec/rubocop/cop/rails/not_null_column_spec.rb:89:8.
To see the complete backtrace run rubocop -d.

rubocop/rubocop#8490 seems to be the cause, it passes with the commit prior to that.

@bbatsov
Copy link
Contributor

bbatsov commented Oct 17, 2020

Yes, that's true. We already discussed this with @bquorning and co in the past and agreed to make this change right before RuboCop 1.0, so extensions can quickly adopt it afterwards.

koic added a commit to koic/rubocop-rails that referenced this issue Oct 19, 2020
This PR disables `RSpec/FactoryBot/CreateList` as a workaround for
rubocop#374.
koic added a commit to koic/rubocop-rails that referenced this issue Oct 19, 2020
This PR disables `RSpec/FactoryBot/CreateList` cop as a workaround for
rubocop#374.
@koic koic closed this as completed Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants