Cop idea: Remove redundant class definition in scopes and class methods

[ydakuka]

Describe the solution you'd like

class ModerationComment < ApplicationRecord
  # bad
  scope :categories, -> { ModerationComment.where(resourceable_type: 'Category') }
  scope :sites,      -> { where ModerationComment.arel_table[:resourceable_type].eq('Site') }

  # bad
  def self.domains
    ModerationComment.where(resourceable_type: 'Domain')
  end

  # good
  scope :categories, -> { where(resourceable_type: 'Category') }
  scope :sites,      -> { where arel_table[:resourceable_type].eq('Site') }

  # good
  def self.domains
    where(resourceable_type: 'Domain')
  end
end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.55.1 (using Parser 3.2.2.3, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.18.0
  - rubocop-factory_bot 2.23.1
  - rubocop-performance 1.18.0
  - rubocop-rails 2.20.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.23.0
  - rubocop-thread_safety 0.5.1

[koic]

I have a concern that the redundancy class name might be specific to inside the scope context or not. The point is whether it has generic beyond just the scope.

[ydakuka]

I think it should be detected by the Style/ClassMethods cop. https://rubystyle.guide/#def-self-class-methods and https://rubystyle.guide/#class-and-self