Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cop idea: Where with Ranges cop #1089

Closed
ydakuka opened this issue Aug 27, 2023 · 1 comment
Closed

Cop idea: Where with Ranges cop #1089

ydakuka opened this issue Aug 27, 2023 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@ydakuka
Copy link

ydakuka commented Aug 27, 2023

Reference: https://rails.rubystyle.guide/#where-ranges

Actual behavior

I have the code:

# frozen_string_literal: true

class User < ApplicationRecord
  def method
    # bad
    User.where('created_at >= ?', 30.days.ago).where('created_at <= ?', 7.days.ago)
    User.where('created_at >= ? AND created_at <= ?', 30.days.ago, 7.days.ago)
    User.where('created_at >= :start AND created_at <= :end', start: 30.days.ago, end: 7.days.ago)

    # bad
    User.where('created_at >= ?', 7.days.ago)
  end
end

I will run rubocop and not get any offences:

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop app/models/user.rb
Inspecting 1 file
.

1 file inspected, no offenses detected

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.55.1 (using Parser 3.2.2.3, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.18.0
  - rubocop-factory_bot 2.23.1
  - rubocop-performance 1.18.0
  - rubocop-rails 2.20.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.23.0
  - rubocop-thread_safety 0.5.1
@koic koic added the duplicate This issue or pull request already exists label Aug 28, 2023
@koic
Copy link
Member

koic commented Aug 28, 2023

This proposal is a dup with #689.

@koic koic closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants