/
where_missing_spec.rb
207 lines (172 loc) · 6.82 KB
/
where_missing_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Rails::WhereMissing, :config do
context 'Rails 6.1', :rails61 do
it 'registers an offense when using `left_joins(foo).where(foos: {id: nil})`' do
expect_offense(<<~RUBY)
Foo.left_joins(:foo).where(foos: { id: nil }).where(bar: "bar")
^^^^^^^^^^^^^^^^ Use `where.missing(:foo)` instead of `left_joins(:foo).where(foos: { id: nil })`.
RUBY
expect_correction(<<~RUBY)
Foo.where.missing(:foo).where(bar: "bar")
RUBY
end
it 'registers an offense when using `left_outer_joins(foo).where(foos: {id: nil})`' do
expect_offense(<<~RUBY)
Foo.left_outer_joins(:foo).where(foos: { id: nil }).where(bar: "bar")
^^^^^^^^^^^^^^^^^^^^^^ Use `where.missing(:foo)` instead of `left_outer_joins(:foo).where(foos: { id: nil })`.
RUBY
expect_correction(<<~RUBY)
Foo.where.missing(:foo).where(bar: "bar")
RUBY
end
it 'registers an offense when using `where(foos: {id: nil}).left_joins(foo)`' do
expect_offense(<<~RUBY)
Foo.where(foos: { id: nil }).left_joins(:foo).where(bar: "bar")
^^^^^^^^^^^^^^^^ Use `where.missing(:foo)` instead of `left_joins(:foo).where(foos: { id: nil })`.
RUBY
expect_correction(<<~RUBY)
Foo.where.missing(:foo).where(bar: "bar")
RUBY
end
it "registers an offense when using `left_joins(foo).where(foos: {id: nil}, bar: 'bar')`" do
expect_offense(<<~RUBY)
Foo.left_joins(:foo).where(foos: { id: nil }, bar: "bar")
^^^^^^^^^^^^^^^^ Use `where.missing(:foo)` instead of `left_joins(:foo).where(foos: { id: nil })`.
RUBY
expect_correction(<<~RUBY)
Foo.where.missing(:foo).where(bar: "bar")
RUBY
end
it "registers an offense when using `left_joins(foo).where(bar: 'bar', foos: {id: nil})`" do
expect_offense(<<~RUBY)
Foo.left_joins(:foo).where(bar: "bar", foos: { id: nil })
^^^^^^^^^^^^^^^^ Use `where.missing(:foo)` instead of `left_joins(:foo).where(foos: { id: nil })`.
RUBY
expect_correction(<<~RUBY)
Foo.where.missing(:foo).where(bar: "bar")
RUBY
end
it 'registers an offense when using `where(foos: {id: nil}).joins(:bar).left_joins(foo)`' do
expect_offense(<<~RUBY)
Foo.left_joins(:foo).joins(:bar).where(foos: { id: nil })
^^^^^^^^^^^^^^^^ Use `where.missing(:foo)` instead of `left_joins(:foo).where(foos: { id: nil })`.
RUBY
expect_correction(<<~RUBY)
Foo.where.missing(:foo).joins(:bar)
RUBY
end
it 'registers an offense when using `left_joins(foo).where(foos: {id: nil})` with multi-line leading ' \
'dot method calls' do
expect_offense(<<~RUBY)
Foo
.left_joins(:foo)
^^^^^^^^^^^^^^^^ Use `where.missing(:foo)` instead of `left_joins(:foo).where(foos: { id: nil })`.
.where(foos: { id: nil })
.where(bar: "bar")
RUBY
expect_correction(<<~RUBY)
Foo
.where.missing(:foo)
.where(bar: "bar")
RUBY
end
it 'registers an offense when using `left_joins(foo).where(foos: {id: nil})` with multi-line trailing ' \
'dot method calls' do
expect_offense(<<~RUBY)
Foo.
left_joins(:foo).
^^^^^^^^^^^^^^^^ Use `where.missing(:foo)` instead of `left_joins(:foo).where(foos: { id: nil })`.
where(foos: { id: nil }).
where(bar: "bar")
RUBY
expect_correction(<<~RUBY)
Foo.
where.missing(:foo).
where(bar: "bar")
RUBY
end
it 'registers an offense when using `left_joins(foo).where(foos: {id: nil})` and there is a line break after' \
'`left_joins.where`' do
expect_offense(<<~RUBY)
Foo.left_joins(:foo).where(foos: { id: nil })
^^^^^^^^^^^^^^^^ Use `where.missing(:foo)` instead of `left_joins(:foo).where(foos: { id: nil })`.
.where(bar: "bar")
RUBY
expect_correction(<<~RUBY)
Foo.where.missing(:foo)
.where(bar: "bar")
RUBY
end
it 'registers an offense when using `left_joins(foo).where(foos: {id: nil})` and there is a line break after' \
'`left_joins.where` and receiver' do
expect_offense(<<~RUBY)
Foo
.left_joins(:foo).where(foos: { id: nil })
^^^^^^^^^^^^^^^^ Use `where.missing(:foo)` instead of `left_joins(:foo).where(foos: { id: nil })`.
.where(bar: "bar")
RUBY
expect_correction(<<~RUBY)
Foo
.where.missing(:foo)
.where(bar: "bar")
RUBY
end
it "registers an offense when using `left_joins(foo).where(foos: {id: nil}, bar: 'bar')`" \
'with other `left_joins(:foo)`' do
expect_offense(<<~RUBY)
def test
Foo.left_joins(:foo).any?
do_something
Foo.left_joins(:foo).where(foos: {id: nil})
^^^^^^^^^^^^^^^^ Use `where.missing(:foo)` instead of `left_joins(:foo).where(foos: { id: nil })`.
end
RUBY
expect_correction(<<~RUBY)
def test
Foo.left_joins(:foo).any?
do_something
Foo.where.missing(:foo)
end
RUBY
end
it "registers an offense when using `left_joins(foo).where(foos: {id: nil}, bar: 'bar')`" \
"with other `left_joins(:foo).where(foos: {id: nil}, bar: 'bar')`" do
expect_offense(<<~RUBY)
def test
Foo.left_joins(:foo).where(foos: {id: nil})
^^^^^^^^^^^^^^^^ Use `where.missing(:foo)` instead of `left_joins(:foo).where(foos: { id: nil })`.
do_something
Foo.left_joins(:foo).where(foos: {id: nil})
^^^^^^^^^^^^^^^^ Use `where.missing(:foo)` instead of `left_joins(:foo).where(foos: { id: nil })`.
end
RUBY
expect_correction(<<~RUBY)
def test
Foo.where.missing(:foo)
do_something
Foo.where.missing(:foo)
end
RUBY
end
it 'does not register an offense when not finding missing relationship records' do
expect_no_offenses(<<~RUBY)
Foo.left_joins(:foo).where(bazs: { id: nil })
Foo.left_joins(:foo).where(foos: { name: nil })
Foo.left_joins(:foo).where(foos: { id: 1 })
Foo.left_joins(foo: :bar).where(bars: { id: nil })
RUBY
end
end
context 'Rails 6.0', :rails60 do
it 'does not register an offense when using `left_joins(foo).where(foos: {id: nil})`' do
expect_no_offenses(<<~RUBY)
Foo.left_joins(:foo).where(foos: { id: nil }).where(bar: "bar")
RUBY
end
it 'does not register an offense when using `left_outer_joins(foo).where(foos: {id: nil})`' do
expect_no_offenses(<<~RUBY)
Foo.left_outer_joins(:foo).where(foos: { id: nil }).where(bar: "bar")
RUBY
end
end
end