action_controller_flash_before_render_spec.rb

# frozen_string_literal: true

RSpec.describe RuboCop::Cop::Rails::ActionControllerFlashBeforeRender, :config do
  context 'within a rails controller class' do
    context 'within an instance method' do
      context 'when using `flash` before `render`' do
        it 'registers an offense and corrects' do
          expect_offense(<<~RUBY)
            class HomeController < ApplicationController
              def create
                flash[:alert] = "msg"
                ^^^^^ Use `flash.now` before `render`.
                render :index
              end
            end
          RUBY

          expect_correction(<<~RUBY)
            class HomeController < ApplicationController
              def create
                flash.now[:alert] = "msg"
                render :index
              end
            end
          RUBY
        end
      end

      context 'when using `flash` before `redirect_to`' do
        it 'does not register an offense' do
          expect_no_offenses(<<~RUBY)
            class HomeController < ApplicationController
              def create
                flash[:alert] = "msg"
                redirect_to "https://www.google.com/"
              end
            end
          RUBY
        end
      end
    end

    context 'within a class method' do
      it 'does not register an offense' do
        expect_no_offenses(<<~RUBY)
          class HomeController < ApplicationController
            def self.create
              flash[:alert] = "msg"
              render :index
            end
          end
        RUBY
      end
    end

    context 'within a block' do
      it 'registers an offense and corrects' do
        expect_offense(<<~RUBY)
          class HomeController < ApplicationController
            before_action do
              flash[:alert] = "msg"
              ^^^^^ Use `flash.now` before `render`.
              render :index
            end
          end
        RUBY

        expect_correction(<<~RUBY)
          class HomeController < ApplicationController
            before_action do
              flash.now[:alert] = "msg"
              render :index
            end
          end
        RUBY
      end
    end

    it 'does not register an offense' do
      expect_no_offenses(<<~RUBY)
        class HomeController < ApplicationController
          flash[:alert] = "msg"
          render :index
        end
      RUBY
    end
  end

  context 'within a non rails controller class' do
    it 'does not register an offense' do
      expect_no_offenses(<<~RUBY)
        class NonController < ApplicationRecord
          def create
            flash[:alert] = "msg"
            render :index
          end
        end
      RUBY
    end
  end
end