/
enum_uniqueness_spec.rb
117 lines (103 loc) · 3.88 KB
/
enum_uniqueness_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Rails::EnumUniqueness, :config do
subject(:cop) { described_class.new }
context 'when array syntax is used' do
context 'with a single duplicated enum value' do
it 'registers an offense' do
expect_offense(<<~RUBY)
enum status: [:active, :archived, :active]
^^^^^^^ Duplicate value `:active` found in `status` enum declaration.
RUBY
end
end
context 'with several duplicated enum values' do
it 'registers two offenses' do
expect_offense(<<~RUBY)
enum status: [:active, :archived, :active, :active]
^^^^^^^ Duplicate value `:active` found in `status` enum declaration.
^^^^^^^ Duplicate value `:active` found in `status` enum declaration.
RUBY
end
end
context 'with no duplicated enum values' do
it 'does not register an offense for unique enum values' do
expect_no_offenses('enum status: [:active, :archived]')
end
end
end
context 'when hash syntax is used' do
context 'with a single duplicated enum value' do
it 'registers an offense' do
expect_offense(<<~RUBY)
enum status: { active: 0, archived: 0 }
^ Duplicate value `0` found in `status` enum declaration.
RUBY
end
end
context 'with several duplicated enum values' do
it 'registers two offenses' do
expect_offense(<<~RUBY)
enum status: { active: 0, pending: 0, archived: 0 }
^ Duplicate value `0` found in `status` enum declaration.
^ Duplicate value `0` found in `status` enum declaration.
RUBY
end
end
context 'with no duplicated enum values' do
it 'does not register an offense' do
expect_no_offenses('enum status: { active: 0, pending: 1 }')
end
end
end
context 'when receiving a variable' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
var = { status: { active: 0, archived: 1 } }
enum var
RUBY
end
end
context 'when receiving a hash without literal values' do
context 'when value is a variable' do
it 'does not register an offense' do
expect_no_offenses('enum status: statuses')
end
end
context 'when value is a method chain' do
it 'does not register an offense' do
expect_no_offenses('enum status: User.statuses.keys')
end
end
context 'when value is a constant' do
it 'does not register an offense' do
expect_no_offenses('enum status: STATUSES')
end
end
end
context 'when the enum name is a string' do
it 'registers an offense' do
expect_offense(<<~RUBY)
enum "status" => [:active, :archived, :active]
^^^^^^^ Duplicate value `:active` found in `status` enum declaration.
RUBY
end
end
context 'when the enum name is not a literal' do
it 'registers an offense' do
expect_offense(<<~RUBY)
enum KEY => [:active, :archived, :active]
^^^^^^^ Duplicate value `:active` found in `KEY` enum declaration.
RUBY
end
end
context 'with multiple enum definition for a `enum` method call' do
it 'registers an offense' do
expect_offense(<<~RUBY)
enum status: [:active, :archived, :active],
^^^^^^^ Duplicate value `:active` found in `status` enum declaration.
role: [:owner, :member, :guest, :member]
^^^^^^^ Duplicate value `:member` found in `role` enum declaration.
RUBY
end
end
end