/
compact_blank_spec.rb
128 lines (107 loc) · 3.67 KB
/
compact_blank_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Rails::CompactBlank, :config do
context 'Rails >= 6.1', :rails61 do
it 'registers and corrects an offense when using `reject { |e| e.blank? }`' do
expect_offense(<<~RUBY)
collection.reject { |e| e.blank? }
^^^^^^^^^^^^^^^^^^^^^^^ Use `compact_blank` instead.
RUBY
expect_correction(<<~RUBY)
collection.compact_blank
RUBY
end
it 'registers and corrects an offense when using `reject(&:blank?)`' do
expect_offense(<<~RUBY)
collection.reject(&:blank?)
^^^^^^^^^^^^^^^^ Use `compact_blank` instead.
RUBY
expect_correction(<<~RUBY)
collection.compact_blank
RUBY
end
it 'registers and corrects an offense when using `delete_if { |e| e.blank? }`' do
expect_offense(<<~RUBY)
collection.delete_if { |e| e.blank? }
^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `compact_blank!` instead.
RUBY
expect_correction(<<~RUBY)
collection.compact_blank!
RUBY
end
it 'registers and corrects an offense when using `delete_if(&:blank?)`' do
expect_offense(<<~RUBY)
collection.delete_if(&:blank?)
^^^^^^^^^^^^^^^^^^^ Use `compact_blank!` instead.
RUBY
expect_correction(<<~RUBY)
collection.compact_blank!
RUBY
end
it 'registers and corrects an offense when using `reject! { |e| e.blank? }`' do
expect_offense(<<~RUBY)
collection.reject! { |e| e.blank? }
^^^^^^^^^^^^^^^^^^^^^^^^ Use `compact_blank!` instead.
RUBY
expect_correction(<<~RUBY)
collection.compact_blank!
RUBY
end
it 'registers and corrects an offense when using `reject!(&:blank?)`' do
expect_offense(<<~RUBY)
collection.reject!(&:blank?)
^^^^^^^^^^^^^^^^^ Use `compact_blank!` instead.
RUBY
expect_correction(<<~RUBY)
collection.compact_blank!
RUBY
end
it 'registers and corrects an offense when using reject(&:blank?) in block' do
expect_offense(<<~RUBY)
hash.transform_values { |value| value.reject(&:blank?) }
^^^^^^^^^^^^^^^^ Use `compact_blank` instead.
RUBY
expect_correction(<<~RUBY)
hash.transform_values { |value| value.compact_blank }
RUBY
end
it 'does not register an offense when using `compact_blank`' do
expect_no_offenses(<<~RUBY)
collection.compact_blank
RUBY
end
it 'does not register an offense when using `compact_blank!`' do
expect_no_offenses(<<~RUBY)
collection.compact_blank!
RUBY
end
it 'does not register an offense when using `reject { |k, v| k.blank? }`' do
expect_no_offenses(<<~RUBY)
collection.reject { |k, v| k.blank? }
RUBY
end
it 'does not register an offense when using the receiver of `blank?` is not a block variable' do
expect_no_offenses(<<~RUBY)
def foo(arg)
collection.reject { |_| arg.blank? }
end
RUBY
end
it 'does not register an offense when using `reject { |e| e.empty? }`' do
expect_no_offenses(<<~RUBY)
collection.reject { |e| e.empty? }
RUBY
end
end
context 'Rails <= 6.0', :rails60 do
it 'does not register an offense when using `reject { |e| e.blank? }`' do
expect_no_offenses(<<~RUBY)
collection.reject { |e| e.blank? }
RUBY
end
it 'does not register an offense when using `reject { |e| e.empty? }`' do
expect_no_offenses(<<~RUBY)
collection.reject { |e| e.empty? }
RUBY
end
end
end