Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support numbered parameter for RedundantSortBlock, SortReverse, and TimesMap #305

Merged
merged 1 commit into from Sep 10, 2022

Conversation

koic
Copy link
Member

@koic koic commented Sep 10, 2022

This PR support numbered parameter for Performance/RedundantSortBlock, Performance/SortReverse, and Performance/TimesMap cops.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…nd `TimesMap`

This PR support numbered parameter for `Performance/RedundantSortBlock`,
`Performance/SortReverse`, and `Performance/TimesMap` cops.
@koic koic changed the title Support numbered parameter for RedundantSortBlock, SortReverse, and TimesMap. Support numbered parameter for RedundantSortBlock, SortReverse, and TimesMap Sep 10, 2022
@koic koic merged commit d9c6ea2 into rubocop:master Sep 10, 2022
@koic koic deleted the support_numbered_parameter branch September 10, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant