Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cimg/ruby instead of deprecated circleci/ruby image #301

Merged
merged 1 commit into from Aug 31, 2022

Conversation

koic
Copy link
Member

@koic koic commented Aug 31, 2022

Follow up f2b1319f.

circleci/ruby image is also deprecated. And cimg/ruby image cannot be used, cimg/ruby:3.1 is used instead.

Starting container cimg/ruby
Warning: No authentication provided, using CircleCI credentials for pulls from Docker Hub.
  image cache not found on this host, downloading cimg/ruby

Error response from daemon: manifest for cimg/ruby:latest not found: manifest unknown: manifest unknown

https://app.circleci.com/pipelines/github/rubocop/rubocop-performance/789/workflows/e2da53d9-cd49-46a0-aacf-040bb50606b1/jobs/5240


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the use_cimg_ruby_instead_of_circleci_ruby branch from 5f538cd to 0422da6 Compare August 31, 2022 01:44
@koic koic merged commit 975d32a into rubocop:master Aug 31, 2022
@koic koic deleted the use_cimg_ruby_instead_of_circleci_ruby branch August 31, 2022 01:50
koic added a commit to rubocop/rubocop-rails that referenced this pull request Aug 31, 2022
koic added a commit to rubocop/rubocop-minitest that referenced this pull request Aug 31, 2022
koic added a commit to rubocop/circleci-ruby-snapshot-image that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant