Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #289] Fix a false positive for Performance/StringIdentifierArgument #290

Conversation

koic
Copy link
Member

@koic koic commented May 18, 2022

Fixes #289.

This PR fixes a false positive for Performance/StringIdentifierArgument when using namespaced class string argument.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…ierArgument`

Fixes rubocop#289.

This PR fixes a false positive for `Performance/StringIdentifierArgument`
when using namespaced class string argument.
@koic koic force-pushed the fix_a_false_positive_for_performance_string_identifier_argument branch from 3077bcf to b0b47e7 Compare May 18, 2022 16:55
@koic koic merged commit 9dba637 into rubocop:master May 21, 2022
@koic koic deleted the fix_a_false_positive_for_performance_string_identifier_argument branch May 21, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance/StringIdentifierArgument unsafe autocorrection
1 participant