Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cop to prevent regexp literals as arguments to assert_matches #179

Merged

Conversation

rwstauner
Copy link
Contributor

Add a cop that checks for regular expression literals being passed to assert_raises.

These will not validate the message for the raised exception but will generate a potentially confusing TypeError when the expected exception does not raise.

I didn't see docs for updating config/default.yml, let me know if I need to change that.

Thanks!


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

config/default.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@rwstauner rwstauner force-pushed the rwstauner/assert-raises-regexp-literal branch from 794a39c to 788f4ce Compare September 2, 2022 15:50
@rwstauner
Copy link
Contributor Author

thanks for the thorough review and all the explanations!

@rwstauner rwstauner mentioned this pull request Sep 2, 2022
8 tasks
@koic koic merged commit bfeac82 into rubocop:master Sep 3, 2022
@koic
Copy link
Member

koic commented Sep 3, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants