Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #183] Fix an error for Minitest/AssertMatch #184

Merged
merged 1 commit into from Sep 17, 2022

Conversation

koic
Copy link
Member

@koic koic commented Sep 15, 2022

Fixes #183.

This PR fixes an error for Minitest/AssertMatch when using assert with no arguments match.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#183.

This PR fixes an error for `Minitest/AssertMatch` when using `assert` with no arguments `match`.
@koic koic force-pushed the fix_an_error_for_minitest_assert_match branch from d055d3b to 8c55d81 Compare September 16, 2022 02:32
@koic koic merged commit c7ea346 into rubocop:master Sep 17, 2022
@koic koic deleted the fix_an_error_for_minitest_assert_match branch September 17, 2022 15:22
koic added a commit to koic/rubocop-minitest that referenced this pull request Sep 27, 2022
Follow up rubocop#181 and rubocop#184.

This PR fixes an incorrect autocorrect for `Minitest/AssertMatch`
when `refute` with `match` and RHS is a regexp literal.

A regular expression literal must be the first argument to `refute_match`.
`TypeError: no implicit conversion of Regexp into String` will occur if it is
passed as the second argument.

```ruby
refute_match(object, /regexp/) #=> TypeError: no implicit conversion of Regexp into String
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minitest/AssertMatch return error code
1 participant