Fix raise error when usgin assert with block #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ippachi
force-pushed
the
fix-assert-with-block
branch
from
e609604
to
c04885e
Compare
|
Can you refactor to the following? diff --git a/lib/rubocop/cop/mixin/predicate_assertion_handleable.rb b/lib/rubocop/cop/mixin/predicate_assertion_handleable.rb
index 4a0f204..5269553 100644
--- a/lib/rubocop/cop/mixin/predicate_assertion_handleable.rb
+++ b/lib/rubocop/cop/mixin/predicate_assertion_handleable.rb
@@ -13,7 +13,10 @@ module RuboCop
first_argument = arguments.first
- return if no_offense_first_argument?(first_argument)
+ return unless first_argument
+ return if first_argument.block_type? || first_argument.numblock_type?
+ return unless predicate_method?(first_argument)
+ return unless first_argument.arguments.count.zero?
add_offense(node, message: offense_message(arguments)) do |corrector|
autocorrect(corrector, node, arguments)
@@ -36,6 +39,10 @@ module RuboCop
peel_redundant_parentheses_from(arguments.first.children)
end
+ def predicate_method?(first_argument)
+ first_argument.respond_to?(:predicate_method?) && first_argument.predicate_method?
+ end
+
def offense_message(arguments)
message_argument = arguments.last if arguments.first != arguments.last
@@ -57,15 +64,6 @@ module RuboCop
def correct_receiver(receiver)
receiver ? receiver.source : 'self'
end
-
- def no_offense_first_argument?(first_argument)
- return true unless first_argument
- return true if first_argument.block_type? || first_argument.numblock_type?
- return true unless first_argument.respond_to?(:predicate_method?) && first_argument.predicate_method?
- return true unless first_argument.arguments.count.zero?
-
- false
- end
end
end
endSo, |
koic
reviewed
Jun 13, 2022
| @@ -0,0 +1 @@ | |||
| * Fix raise error when using assert with block. ([@ippachi][]) | |||
There was a problem hiding this comment.
Can you add the pull request address?
Suggested change
| * Fix raise error when using assert with block. ([@ippachi][]) | |
| * [#175](https://github.com/rubocop/rubocop-minitest/pull/175): Fix raise error when using assert with block. ([@ippachi][]) |
ippachi
force-pushed
the
fix-assert-with-block
branch
from
c04885e
to
c9bd43a
Compare
|
Thanks for the fast response! |
|
Good catch and great work! RuboCop Minitest 0.20.1 has been released. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rubocop-minitest was raising error if the style was to pass a block to an assert, such as power-assert.
So, I made it so that such cases are ignored.
This is stacktrace.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.