-
-
Notifications
You must be signed in to change notification settings - Fork 12
/
consistent_parentheses_style_spec.rb
351 lines (301 loc) · 9.31 KB
/
consistent_parentheses_style_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::RSpec::FactoryBot::ConsistentParenthesesStyle do
let(:cop_config) do
{ 'EnforcedStyle' => enforced_style }
end
context 'when EnforcedStyle is :enforce_parentheses' do
let(:enforced_style) { :require_parentheses }
context 'with create' do
it 'flags the call to use parentheses' do
expect_offense(<<~RUBY)
create :user
^^^^^^ Prefer method call with parentheses
RUBY
expect_correction(<<~RUBY)
create(:user)
RUBY
end
end
context 'with multiline method calls' do
it 'expects parentheses around multiline call' do
expect_offense(<<~RUBY)
create :user,
^^^^^^ Prefer method call with parentheses
username: "PETER",
peter: "USERNAME"
RUBY
expect_correction(<<~RUBY)
create(:user,
username: "PETER",
peter: "USERNAME")
RUBY
end
end
context 'with build' do
it 'flags the call to use parentheses' do
expect_offense(<<~RUBY)
build :user
^^^^^ Prefer method call with parentheses
RUBY
expect_correction(<<~RUBY)
build(:user)
RUBY
end
end
context 'with mixed tests' do
it 'flags the call to use parentheses' do
expect_offense(<<~RUBY)
build_list :user, 10
^^^^^^^^^^ Prefer method call with parentheses
build_list "user", 10
^^^^^^^^^^ Prefer method call with parentheses
create_list :user, 10
^^^^^^^^^^^ Prefer method call with parentheses
build_stubbed :user
^^^^^^^^^^^^^ Prefer method call with parentheses
build_stubbed_list :user, 10
^^^^^^^^^^^^^^^^^^ Prefer method call with parentheses
build factory
^^^^^ Prefer method call with parentheses
RUBY
expect_correction(<<~RUBY)
build_list(:user, 10)
build_list("user", 10)
create_list(:user, 10)
build_stubbed(:user)
build_stubbed_list(:user, 10)
build(factory)
RUBY
end
end
context 'with nested calling' do
it 'flags the call to use parentheses' do
expect_offense(<<~RUBY)
build :user, build(:yester)
^^^^^ Prefer method call with parentheses
RUBY
expect_correction(<<~RUBY)
build(:user, build(:yester))
RUBY
end
it 'works in a bigger context' do
expect_offense(<<~RUBY)
context 'with context' do
let(:build) { create :user, build(:user) }
^^^^^^ Prefer method call with parentheses
it 'test in test' do
user = create :user, first: name, peter: miller
^^^^^^ Prefer method call with parentheses
end
let(:build) { create :user, build(:user, create(:user, create(:first_name))) }
^^^^^^ Prefer method call with parentheses
end
RUBY
expect_correction(<<~RUBY)
context 'with context' do
let(:build) { create(:user, build(:user)) }
it 'test in test' do
user = create(:user, first: name, peter: miller)
end
let(:build) { create(:user, build(:user, create(:user, create(:first_name)))) }
end
RUBY
end
end
context 'with already valid usage of parentheses' do
it 'does not flag as invalid - create' do
expect_no_offenses(<<~RUBY)
create(:user)
RUBY
end
it 'does not flag as invalid - build' do
expect_no_offenses(<<~RUBY)
build(:user)
RUBY
end
end
it 'flags the call with an explicit receiver' do
expect_offense(<<~RUBY)
FactoryBot.create :user
^^^^^^ Prefer method call with parentheses
RUBY
end
it 'ignores FactoryBot DSL methods without a first positional argument' do
expect_no_offenses(<<~RUBY)
create
create foo: :bar
RUBY
end
end
context 'when EnforcedStyle is :omit_parentheses' do
let(:enforced_style) { :omit_parentheses }
context 'with create' do
it 'flags the call to not use parentheses' do
expect_offense(<<~RUBY)
create(:user)
^^^^^^ Prefer method call without parentheses
RUBY
expect_correction(<<~RUBY)
create :user
RUBY
end
end
context 'with nest call' do
it 'inner call is ignored and not fixed' do
expect_no_offenses(<<~RUBY)
puts(1, create(:user))
RUBY
end
end
context 'with multiline method calls' do
it 'removes parentheses around multiline call' do
expect_offense(<<~RUBY)
create(:user,
^^^^^^ Prefer method call without parentheses
username: "PETER",
peter: "USERNAME")
RUBY
expect_correction(<<~RUBY)
create :user,
username: "PETER",
peter: "USERNAME"
RUBY
end
end
context 'with mixed tests' do
it 'flags the call not to use parentheses' do
expect_offense(<<~RUBY)
build_list(:user, 10)
^^^^^^^^^^ Prefer method call without parentheses
build_list("user", 10)
^^^^^^^^^^ Prefer method call without parentheses
create_list(:user, 10)
^^^^^^^^^^^ Prefer method call without parentheses
build_stubbed(:user)
^^^^^^^^^^^^^ Prefer method call without parentheses
build_stubbed_list(:user, 10)
^^^^^^^^^^^^^^^^^^ Prefer method call without parentheses
build(factory)
^^^^^ Prefer method call without parentheses
RUBY
expect_correction(<<~RUBY)
build_list :user, 10
build_list "user", 10
create_list :user, 10
build_stubbed :user
build_stubbed_list :user, 10
build factory
RUBY
end
end
context 'with build' do
it 'flags the call to not use parentheses' do
expect_offense(<<~RUBY)
build(:user)
^^^^^ Prefer method call without parentheses
RUBY
expect_correction(<<~RUBY)
build :user
RUBY
end
end
context 'with nested calling' do
it 'flags the call to use parentheses' do
expect_offense(<<~RUBY)
build(:user, build(:yester))
^^^^^ Prefer method call without parentheses
RUBY
expect_correction(<<~RUBY)
build :user, build(:yester)
RUBY
end
end
context 'with nested calling that does not require fixing' do
it 'does not flag the nested call' do
expect_no_offenses(<<~RUBY)
build :user, build(:yester)
RUBY
end
end
context 'with already valid usage of parentheses' do
it 'does not flag as invalid - create' do
expect_no_offenses(<<~RUBY)
create :user
RUBY
end
it 'does not flag as invalid - build' do
expect_no_offenses(<<~RUBY)
build :user
RUBY
end
end
it 'works in a bigger context' do
expect_offense(<<~RUBY)
RSpec.describe Context do
let(:build) { create(:user, build(:user)) }
^^^^^^ Prefer method call without parentheses
it 'test in test' do
user = create(:user, first: name, peter: miller)
^^^^^^ Prefer method call without parentheses
end
let(:build) { create(:user, build(:user, create(:user, create(:first_name)))) }
^^^^^^ Prefer method call without parentheses
end
RUBY
expect_correction(<<~RUBY)
RSpec.describe Context do
let(:build) { create :user, build(:user) }
it 'test in test' do
user = create :user, first: name, peter: miller
end
let(:build) { create :user, build(:user, create(:user, create(:first_name))) }
end
RUBY
end
context 'when create and first argument are on same line' do
it 'register an offense' do
expect_offense(<<~RUBY)
create(:user,
^^^^^^ Prefer method call without parentheses
name: 'foo'
)
RUBY
expect_correction(<<~RUBY)
create :user,
name: 'foo'
RUBY
end
end
context 'when create and first argument are not on same line' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
create(
:user
)
RUBY
end
end
context 'when create and some argument are not on same line' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
create(
:user,
name: 'foo'
)
RUBY
end
end
it 'flags the call with an explicit receiver' do
expect_offense(<<~RUBY)
FactoryBot.create(:user)
^^^^^^ Prefer method call without parentheses
RUBY
end
it 'ignores FactoryBot DSL methods without a first positional argument' do
expect_no_offenses(<<~RUBY)
create()
create(foo: :bar)
RUBY
end
end
end