From b117b3955ee107522663172437cfaed0f20c3d49 Mon Sep 17 00:00:00 2001
From: Marc-Andre Lafortune <github@marc-andre.ca>
Date: Wed, 26 May 2021 10:43:48 -0400
Subject: [PATCH] Revert "Improve `parent_module_name` (#177)"

This reverts commit e303401077dba688441e6331b191290030a3ae09.
---
 ..._on_rubocop_ast_node_parent_module_name.md |  1 -
 lib/rubocop/ast/node.rb                       |  8 ++-
 spec/rubocop/ast/node_pattern_spec.rb         |  1 +
 spec/rubocop/ast/node_spec.rb                 | 69 +------------------
 4 files changed, 7 insertions(+), 72 deletions(-)
 delete mode 100644 changelog/fix_fix_unexpected_nonlocal_exits_on_rubocop_ast_node_parent_module_name.md

diff --git a/changelog/fix_fix_unexpected_nonlocal_exits_on_rubocop_ast_node_parent_module_name.md b/changelog/fix_fix_unexpected_nonlocal_exits_on_rubocop_ast_node_parent_module_name.md
deleted file mode 100644
index 70646bc5e..000000000
--- a/changelog/fix_fix_unexpected_nonlocal_exits_on_rubocop_ast_node_parent_module_name.md
+++ /dev/null
@@ -1 +0,0 @@
-* [#176](https://github.com/rubocop-hq/rubocop-ast/pull/176): Fix unexpected non-local exits on  Rubocop::AST::Node#parent_module_name. ([@sanfrecce-osaka][])
diff --git a/lib/rubocop/ast/node.rb b/lib/rubocop/ast/node.rb
index 7cad4b5fa..98fddd52d 100644
--- a/lib/rubocop/ast/node.rb
+++ b/lib/rubocop/ast/node.rb
@@ -612,17 +612,19 @@ def while_until_value_used?
       def parent_module_name_part(node)
         case node.type
         when :class, :module, :casgn
-          # TODO: if constant name has cbase (leading ::), then we must not
-          # keep traversing up through nested classes/modules
+          # TODO: if constant name has cbase (leading ::), then we don't need
+          # to keep traversing up through nested classes/modules
           node.defined_module_name
         when :sclass
-          parent_module_name_for_sclass(node)
+          yield parent_module_name_for_sclass(node)
         else # block
           parent_module_name_for_block(node) { yield nil }
         end
       end
 
       def parent_module_name_for_sclass(sclass_node)
+        # TODO: look for constant definition and see if it is nested
+        # inside a class or module
         subject = sclass_node.children[0]
 
         if subject.const_type?
diff --git a/spec/rubocop/ast/node_pattern_spec.rb b/spec/rubocop/ast/node_pattern_spec.rb
index b53dbd3a4..a2a6638a3 100644
--- a/spec/rubocop/ast/node_pattern_spec.rb
+++ b/spec/rubocop/ast/node_pattern_spec.rb
@@ -10,6 +10,7 @@ def parse(code)
     builder = RuboCop::AST::Builder.new
     Parser::CurrentRuby.new(builder).parse(buffer)
   end
+
   let(:root_node) { parse(ruby) }
   let(:node) { root_node }
   let(:params) { [] }
diff --git a/spec/rubocop/ast/node_spec.rb b/spec/rubocop/ast/node_spec.rb
index ec534b76e..d27828b80 100644
--- a/spec/rubocop/ast/node_spec.rb
+++ b/spec/rubocop/ast/node_spec.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::AST::Node do
-  let(:ast) { parse_source(src).node }
+  let(:ast) { RuboCop::AST::ProcessedSource.new(src, ruby_version).ast }
   let(:node) { ast }
 
   describe '#value_used?' do
@@ -659,71 +659,4 @@ def variables; end
       end
     end
   end
-
-  describe '#parent_module_name' do
-    subject(:parent_module_name) { node.parent_module_name }
-    context 'when node on top level' do
-      let(:src) { 'def config; end' }
-
-      it { is_expected.to eq 'Object' }
-    end
-
-    context 'when node on module' do
-      let(:src) do
-        <<~RUBY
-          module Foo
-            >>attr_reader :config<<
-          end
-        RUBY
-      end
-
-      it { is_expected.to eq 'Foo' }
-    end
-
-    context 'when node on singleton class' do
-      let(:src) do
-        <<~RUBY
-          module Foo
-            class << self
-              >>attr_reader :config<<
-            end
-          end
-        RUBY
-      end
-
-      it { is_expected.to eq 'Foo::#<Class:Foo>' }
-    end
-
-    context 'when node on class in singleton class' do
-      let(:src) do
-        <<~RUBY
-          module Foo
-            class << self
-              class Bar
-                >>attr_reader :config<<
-              end
-            end
-          end
-        RUBY
-      end
-
-      it { is_expected.to eq 'Foo::#<Class:Foo>::Bar' }
-    end
-
-    context 'when node nested in an unknown block' do
-      let(:src) do
-        <<~RUBY
-          module Foo
-            foo do
-              class Bar
-                >>attr_reader :config<<
-              end
-            end
-          end
-        RUBY
-      end
-
-      it { is_expected.to eq nil }
-    end
-  end
 end