From 2817ae4bcb2677f56fbcdbb8b92ada8dbff3676d Mon Sep 17 00:00:00 2001 From: Marc-Andre Lafortune Date: Fri, 19 Jun 2020 10:36:26 -0400 Subject: [PATCH] Run internal investigation using master only. Fix disabling --- .github/workflows/rubocop.yml | 2 +- lib/rubocop/ast/node.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/rubocop.yml b/.github/workflows/rubocop.yml index 15675bf27..f93c92642 100644 --- a/.github/workflows/rubocop.yml +++ b/.github/workflows/rubocop.yml @@ -66,7 +66,7 @@ jobs: if: matrix.coverage != true run: bundle exec rake spec - name: internal_investigation - if: "matrix.os != 'windows' && matrix.coverage != true" + if: "matrix.os != 'windows' && matrix.coverage != true && matrix.rubocop == 'master'" run: bundle exec rake internal_investigation rubocop_specs: name: >- diff --git a/lib/rubocop/ast/node.rb b/lib/rubocop/ast/node.rb index 483ffc13f..e23b0b665 100644 --- a/lib/rubocop/ast/node.rb +++ b/lib/rubocop/ast/node.rb @@ -505,7 +505,7 @@ def guard_clause? # So, does the return value of this node matter? If we changed it to # `(...; nil)`, might that affect anything? # - # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity + # rubocop:disable Metrics/MethodLength def value_used? # Be conservative and return true if we're not sure. return false if parent.nil? @@ -527,7 +527,7 @@ def value_used? true end end - # rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity + # rubocop:enable Metrics/MethodLength # Some expressions are evaluated for their value, some for their side # effects, and some for both.