Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bundler/setup to Rakefile from spec_helper/test_helper #5

Closed
pravi opened this issue Aug 25, 2020 · 2 comments
Closed

Move bundler/setup to Rakefile from spec_helper/test_helper #5

pravi opened this issue Aug 25, 2020 · 2 comments

Comments

@pravi
Copy link
Collaborator

pravi commented Aug 25, 2020

Many gems do this already, for example puma, ruby-shoulda-context etc. If the bundler/setup require is part of tests, we have to patch it, but having it in Rakefile avoids having to maintain a patch but upstream does not lose out anything as their existing workflow will continue to work.

@utkarsh2102
Copy link
Member

Hey,

Using "bundler/setup" is redundant in tests. We're just removing it's usage altogether.
See here: utkarsh2102/rubocop-packaging#18

This cop will be shortly released once I migrate the documentation from packaging-style-guide to the docs/ in rubocop-packaging, which should be happening soon!

Please let me know if you want to propose something different?
If not, do you think we can close this issue here in the favor of utkarsh2102/rubocop-packaging#18 being released soon?

@pravi
Copy link
Collaborator Author

pravi commented Aug 26, 2020

Sounds good.

@pravi pravi closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants