You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many gems do this already, for example puma, ruby-shoulda-context etc. If the bundler/setup require is part of tests, we have to patch it, but having it in Rakefile avoids having to maintain a patch but upstream does not lose out anything as their existing workflow will continue to work.
The text was updated successfully, but these errors were encountered:
Using "bundler/setup" is redundant in tests. We're just removing it's usage altogether.
See here: utkarsh2102/rubocop-packaging#18
This cop will be shortly released once I migrate the documentation from packaging-style-guide to the docs/ in rubocop-packaging, which should be happening soon!
Please let me know if you want to propose something different?
If not, do you think we can close this issue here in the favor of utkarsh2102/rubocop-packaging#18 being released soon?
Many gems do this already, for example puma, ruby-shoulda-context etc. If the bundler/setup require is part of tests, we have to patch it, but having it in Rakefile avoids having to maintain a patch but upstream does not lose out anything as their existing workflow will continue to work.
The text was updated successfully, but these errors were encountered: