Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for StringConcatenation when concat string includes double quote and interpolation. #9346

Merged
merged 1 commit into from Jan 11, 2021
Merged

Fix an incorrect auto-correct for StringConcatenation when concat string includes double quote and interpolation. #9346

merged 1 commit into from Jan 11, 2021

Conversation

k-karen
Copy link

@k-karen k-karen commented Jan 7, 2021

This PR will resolve following problem.

'"bar"' + foo

after rubocop -A

""bar"#{foo}"

""bar"#{foo}" should be "\"bar\"#{foo}"

This pull request doesn't have related issue.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@k-karen k-karen changed the title Fix an incorrect auto-correct for StringConcatenation with double quote Fix an incorrect auto-correct in StringConcatenation when concat string includes double quote and interpolation. Jan 8, 2021
@k-karen k-karen changed the title Fix an incorrect auto-correct in StringConcatenation when concat string includes double quote and interpolation. Fix an incorrect auto-correct for StringConcatenation when concat string includes double quote and interpolation. Jan 8, 2021
@bbatsov bbatsov merged commit 946d5c3 into rubocop:master Jan 11, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 11, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants