Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Style/MethodCallWithArgsParentheses for endless method definitions #9279

Merged

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented Dec 22, 2020

When an endless method definition calls another method with arguments, parentheses are required or it will be a syntax error. Therefore, parentheses are required even for the omit_parentheses style. If there are no arguments, the method call will continue to be matched to the enforced style as before.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis dvandersluis force-pushed the fix/method-call-with-args-parens branch 2 times, most recently from de1f2ca to c184886 Compare December 22, 2020 20:31
@dvandersluis dvandersluis force-pushed the fix/method-call-with-args-parens branch from c184886 to 9356fba Compare December 23, 2020 08:04
@dvandersluis dvandersluis changed the title Add support for endless methods to Style/MethodCallWithArgsParentheses Fix Style/MethodCallWithArgsParentheses for endless method definitions Dec 23, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Dec 23, 2020

When an endless method definition calls another method with arguments, parentheses are required or it will be a syntax error. Therefore, parentheses are required even for the omit_parentheses style. If there are no arguments, the method call will continue to be matched to the enforced style as before.

I dislike those methods even more now. 😆 You should put this and the other required parens (for defs with no params) into the rationale of the style guide entry.

@bbatsov bbatsov merged commit c538416 into rubocop:master Dec 24, 2020
@dvandersluis dvandersluis deleted the fix/method-call-with-args-parens branch January 18, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants