Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "did you mean" message when failing due to invalid cops in configuration #9171

Merged
merged 1 commit into from Dec 6, 2020

Conversation

dvandersluis
Copy link
Member

@dvandersluis dvandersluis commented Dec 5, 2020

Try to suggest a replacement cop when an invalid cop name is found in the config.

eg:

Error: unrecognized cop Layout/LyneLenth found in .rubocop.yml
Did you mean `Layout/LineLength`?
unrecognized cop Lint/LiteralInCondition found in .rubocop.yml
Did you mean `Lint/LiteralAsCondition`?

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis dvandersluis changed the title Add "did you mean" message when failing due to valid cops Add "did you mean" message when failing due to invalid cops in configuration Dec 5, 2020
@bbatsov bbatsov merged commit 8b8b79d into rubocop:master Dec 6, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Dec 6, 2020

Cool idea! I love it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants