Support auto-correct for Style/SingleLineBlockParams
#9167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR supports auto-correct for `Style/SingleLineBlockParams`.
|
Nice! 🙇♂️ |
koic
deleted the
support_autocorrect_for_style_single_line_block_params
branch
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 5, 2020
Follow rubocop#9167. This PR adds the following project spec and renames the incorrect unreleased entry filename of rubocop#9167. ```console % bundle exec rspec spec/project_spec.rb:239 Randomized with seed 30085 .F Failures: 1) RuboCop Project Changelog future entries For /Users/koic/src/github.com/rubocop-hq/rubocop/spec/../changelog/ support_autocorrect_for_style_single_line_block_params.md starts with `new_`, `fix_`, or `change_` Failure/Error: expect(File.basename(path)).to(match(/\A(new|fix|change)_.+/)) expected "support_autocorrect_for_style_single_line_block_params.md" to match /\A(new|fix|change)_.+/ Diff: @@ -1 +1 @@ -/\A(new|fix|change)_.+/ +"support_autocorrect_for_style_single_line_block_params.md" # ./spec/project_spec.rb:240:in `block (6 levels) in <top (required)>' Finished in 0.01424 seconds (files took 1.53 seconds to load) 2 examples, 1 failure Failed examples: rspec './spec/project_spec.rb[1:3:4:2:5]' # RuboCop Project Changelog future entries For /Users/koic/src/github.com/rubocop-hq/rubocop/spec/../changelog/ support_autocorrect_for_style_single_line_block_params.md starts with `new_`, `fix_`, or `change_` ```
8 tasks
bbatsov
pushed a commit
that referenced
this pull request
Dec 5, 2020
Follow #9167. This PR adds the following project spec and renames the incorrect unreleased entry filename of #9167. ```console % bundle exec rspec spec/project_spec.rb:239 Randomized with seed 30085 .F Failures: 1) RuboCop Project Changelog future entries For /Users/koic/src/github.com/rubocop-hq/rubocop/spec/../changelog/ support_autocorrect_for_style_single_line_block_params.md starts with `new_`, `fix_`, or `change_` Failure/Error: expect(File.basename(path)).to(match(/\A(new|fix|change)_.+/)) expected "support_autocorrect_for_style_single_line_block_params.md" to match /\A(new|fix|change)_.+/ Diff: @@ -1 +1 @@ -/\A(new|fix|change)_.+/ +"support_autocorrect_for_style_single_line_block_params.md" # ./spec/project_spec.rb:240:in `block (6 levels) in <top (required)>' Finished in 0.01424 seconds (files took 1.53 seconds to load) 2 examples, 1 failure Failed examples: rspec './spec/project_spec.rb[1:3:4:2:5]' # RuboCop Project Changelog future entries For /Users/koic/src/github.com/rubocop-hq/rubocop/spec/../changelog/ support_autocorrect_for_style_single_line_block_params.md starts with `new_`, `fix_`, or `change_` ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports auto-correct for
Style/SingleLineBlockParams.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.