AllowedIdentifiers should also check variable assignments. #9136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilCoggins
force-pushed
the
allowed_identifiers_includes_assignments
branch
from
fdcf38c
to
a053fc2
Compare
|
Thanks, this was an oversight in #9017. |
dvandersluis
reviewed
Dec 1, 2020
| @@ -0,0 +1 @@ | |||
| * [#9136](https://github.com/rubocop-hq/rubocop/pull/9136): Fix `AllowedIdentifiers` in `Naming/VariableNumber` to include variable assignments. ([@PhilCoggins][]) | |||
There was a problem hiding this comment.
You need to add your link at the bottom of CHANGELOG.md too.
There was a problem hiding this comment.
Are you talking about link to my GH profile? I followed the formatting in https://github.com/rubocop-hq/rubocop/blob/master/CONTRIBUTING.md#changelog-entry-format which says to use an implicit link?
There was a problem hiding this comment.
Never mind, it's taken care of automatically now. Sorry about that.
|
Thanks! |
PhilCoggins
added a commit
to PhilCoggins/rubocop
that referenced
this pull request
Dec 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9017 Adds
AllowedIdentifiersoption to allow a preconfigured list of names for symbols and method definitions to ignore for theNaming/VariableNumbercop. The cop also checks for variable names, but for whatever reason, does not utilizeAllowedIdentifiers. It is not intuitive thatAllowedIdentifiersonly checks method names and symbols but ignores variable assignment, so therefore it should be included. Further fixes #9012.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.