Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support auto-correction for Style/SoleNestedConditional #9114

Merged

Conversation

koic
Copy link
Member

@koic koic commented Nov 28, 2020

This PR supports auto-correction for Style/SoleNestedConditional.

Part of auto-correction of indentation will be left to other Layout cop.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR supports auto-correction for `Style/SoleNestedConditional`.

Part of auto-correction of indentation will be left to other `Layout` cop.
@bbatsov bbatsov merged commit ef61586 into rubocop:master Nov 29, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Nov 29, 2020

Nicely done!

@koic koic deleted the support_autocorrect_for_sole_nested_conditional branch November 29, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants