Upgrade regexp_parser to 2.0 #9102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods we use that used to return byte-based indices now return char-based indices, so we can revert the changes made in rubocop#8989. https://github.com/ammar/regexp_parser/blob/master/CHANGELOG.md#200---2020-11-25---janosch-m%C3%BCller
knu
force-pushed
the
upgrade_regexp_parser
branch
from
73adc65
to
9b90cae
Compare
|
I was just investigating this too. Thank you for the early catching up and fixing! |
|
Great news, thanks! |
|
This is not a good change. It breaks compatibility with other important gems such as |
|
Sorry about your troubles.
|
|
Update: capybara master is already updated, just not released yet. |
marcandre
added a commit
to marcandre/rubocop
that referenced
this pull request
Dec 2, 2020
marcandre
added a commit
that referenced
this pull request
Dec 2, 2020
|
Thanks for looking into this. It's nice to see Capybara is using RuboCop as well. :-) |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 3, 2020
Follow rubocop#9154, rubocop#9155, and rubocop#9102. This is a step towards the widespread use of regexp_parser 2.0. RuboCop core accepts regexp_parser 1.8, but several code is already incompatible with regexp_parser 1.8. It can cause issue because these combination of versions. Therefore, this PR ports code for regexp_parser 1.8 that will never be maintained from rubocop#9102. Implementation of this patch, code is intentionally duplicated because it is evaluated only when the class is defined. Also, since obsoleted code for regexp_parser 1.8 is assumed to never be maintained, the target to be removed is clear. To be honest, it's ugly as implementation, but I think it has the least impact for RuboCop 1.x series users.
8 tasks
bbatsov
pushed a commit
that referenced
this pull request
Dec 3, 2020
Follow #9154, #9155, and #9102. This is a step towards the widespread use of regexp_parser 2.0. RuboCop core accepts regexp_parser 1.8, but several code is already incompatible with regexp_parser 1.8. It can cause issue because these combination of versions. Therefore, this PR ports code for regexp_parser 1.8 that will never be maintained from #9102. Implementation of this patch, code is intentionally duplicated because it is evaluated only when the class is defined. Also, since obsoleted code for regexp_parser 1.8 is assumed to never be maintained, the target to be removed is clear. To be honest, it's ugly as implementation, but I think it has the least impact for RuboCop 1.x series users.
|
@marcandre Thanks for the changes! I missed that commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regexp_parser 2.0 is out, which introduced char-based indices we wanted.
ammar/regexp_parser#72
ammar/regexp_parser#73
Methods we use that used to return byte-based indices now return char-based indices, so we can revert the changes made in #8989.
https://github.com/ammar/regexp_parser/blob/master/CHANGELOG.md#200---2020-11-25---janosch-m%C3%BCller
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.