Update ConfigObsoletion
so that parameters can be deprecated but still accepted
#9100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9098 it was desired to change some parameters and have a deprecation warning be shown but still accept the old parameters.
ConfigObsoletion
previously would just error if anything was obsolete; this adds a newseverity: :warning
option to theOBSOLETE_PARAMETERS
hash, for which issues will be warned about but rubocop will still complete.I don't have any more tests for this because there is nothing to add to the hash until #9098 is merged, so I'll add them in there once this is accepted.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.