Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ConfigObsoletion so that parameters can be deprecated but still accepted #9100

Merged
merged 1 commit into from Nov 26, 2020

Conversation

dvandersluis
Copy link
Member

In #9098 it was desired to change some parameters and have a deprecation warning be shown but still accept the old parameters. ConfigObsoletion previously would just error if anything was obsolete; this adds a new severity: :warning option to the OBSOLETE_PARAMETERS hash, for which issues will be warned about but rubocop will still complete.

I don't have any more tests for this because there is nothing to add to the hash until #9098 is merged, so I'll add them in there once this is accepted.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis
Copy link
Member Author

/cc @bbatsov

@bbatsov bbatsov merged commit b5357aa into rubocop:master Nov 26, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Nov 26, 2020

Looks good! Thanks!

@dvandersluis dvandersluis deleted the deprecate-parameters branch January 18, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants