[Fix #9095] use merged_config instead of config for pending new cop check

[ThomasKoppensteiner]

Fix for issue #9095

[bbatsov]

Did you manage to figure out when the regression was introduced? Was this in 1.3?

Also - ideally you should add some spec illustrating the impact of the fix.

[ThomasKoppensteiner]

@bbatsov the code was last changed within this commit, but before it also used config.
I think the issue is more related to the introduction of the NewCops option and how it disables the warning.

[ThomasKoppensteiner]

For me it looks like the issue is related to the monkey patching which happens in rubocop-rspec or rt_rubocop_defaults. At least I couldn't reproduce it in otherwise.

[ThomasKoppensteiner]

Btw. is this override still needed, when Rainbow.enabled = false is set in the spec_helper.rb?

[ThomasKoppensteiner]

The following spec fails for me on master as well bundle exec rspec spec/rubocop/cop/style/redundant_regexp_escape_spec.rb:523.

[ThomasKoppensteiner]

@bbatsov and @koic anything else I can do here?

[koic]

The following spec fails for me on master as well bundle exec rspec spec/rubocop/cop/style/redundant_regexp_escape_spec.rb:523.

This failure has been resolved by #9102. Can you rebase with the latest master branch?

[bbatsov]

Seems to me something went wrong with the rebase, as a lot of commits on master appeared in the diff for this branch.

[bbatsov]

Also - don't forget to add a bug-fix entry in the changelog folder.

[ThomasKoppensteiner]

Seems to me something went wrong with the rebase, as a lot of commits on master appeared in the diff for this branch.

Thank you for pointing this out. Did it again, now with command line only.

[bbatsov]

Thanks!

[ThomasKoppensteiner]

@bbatsov do you already know, when this will be released? What is the typical release cycle of rubocop?

[bbatsov]

I plan to do the next release today or tomorrow. Typically I'm aiming for one small release each week/couple of weeks, but I don't pursue any particular release cadence.