Deprecate EnforceSuperclass module`
#9087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuboCop core depended on this module when it supported Rails department. Rails department has been extracted to RuboCop Rails gem. I forgot to remove it when extracting Rails department from the core. rubocop/rubocop-rails#390 is ready to be removed from RuboCop core. First of all, as soft deprecation, the document only indicates that it is a deprecation warning. After releasing RuboCop Rails several times, I will display a deprecation warning and will remove it in RuboCop 2.0.
tejasbubane
reviewed
Nov 24, 2020
| @@ -0,0 +1 @@ | |||
| * [#9087](https://github.com/rubocop-hq/rubocop/pull/9087): Deprecate `EnforceSuperclass` module. ([@koic][]) | |||
There was a problem hiding this comment.
Any reason for not using the main changelog?
There was a problem hiding this comment.
RuboCop core introduces new option to prevent CHANGELOG conflicts. Please see to the bottom of PR checklist for details :-)
Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
There was a problem hiding this comment.
Ohh I missed that. Thanks!
|
Sounds good. I think we should create some RuboCop 2.0 ticket/milestone where we are tracking all changes that we have to do before cutting 2.0, so we won't forget about something. |
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Nov 17, 2021
Follow up to rubocop#9087. This PR displays deprecation message for `EnforceSuperclass` module. > rubocop/rubocop-rails#390 is ready to be removed from RuboCop core. > First of all, as soft deprecation, the document only indicates that it is a deprecation warning. > After releasing RuboCop Rails several times, I will display a deprecation warning and > will remove it in RuboCop 2.0. After rubocop#9087, I've released RuboCop Rails more than 10 times in about a year, so it's time to get a deprecated warning.
bbatsov
pushed a commit
that referenced
this pull request
Nov 17, 2021
Follow up to #9087. This PR displays deprecation message for `EnforceSuperclass` module. > rubocop/rubocop-rails#390 is ready to be removed from RuboCop core. > First of all, as soft deprecation, the document only indicates that it is a deprecation warning. > After releasing RuboCop Rails several times, I will display a deprecation warning and > will remove it in RuboCop 2.0. After #9087, I've released RuboCop Rails more than 10 times in about a year, so it's time to get a deprecated warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuboCop core depended on this module when it supported Rails department. Rails department has been extracted to RuboCop Rails gem. I forgot to remove it when extracting Rails department from the core.
rubocop/rubocop-rails#390 is ready to be removed from RuboCop core.
First of all, as soft deprecation, the document only indicates that it is a deprecation warning.
After releasing RuboCop Rails several times, I will display a deprecation warning and will remove it in RuboCop 2.0.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.