New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying a pull request ID when calling `rake changelog:*` #9074

Merged

mergify merged 1 commit into rubocop:master from marcandre:changelog

Nov 21, 2020

Contributor

marcandre commented Nov 21, 2020 •

edited

Currently:

rake changelog:fix # => issue#666 if commit contains "[Fixes #666]", otherwise pull#x (amend manually later)

This PR adds the possibility to create the PR first, then specify the ID, amend commit and force push:

git push
<create PR> 
rake changelog:fix[42] # => pull#42
git commit -a --amend
git push --force


          Allow specifying a pull request ID when calling rake changelog:*

29dc6b2

marcandre force-pushed the changelog branch from 023a4c6 to 29dc6b2 Compare

November 21, 2020 03:43

marcandre added the auto-merge label

mergify bot merged commit 6d3751a into rubocop:master

marcandre deleted the changelog branch

November 21, 2020 03:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment