-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix stack level too deep error if target directory contains **
#9039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7e95a9d
to
6b15ba3
Compare
I need advice on what to do windows environment... |
6b15ba3
to
79c79b9
Compare
Cannot create a directory with containing So I disabled the test case in Windows... |
79c79b9
to
3fdc92b
Compare
7b48648
to
dd2aaa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The changes look good, but your branch has to be rebased on top of the current |
In the future, you can use the new way to handle changelog entries ( |
Co-authored-by: Koichi ITO <koic.ito@gmail.com> RuboCop exits with SystemStackError because "stack level too deep" if the target directory has the "**" directory. ``` foo └── ** └── bar.rb ``` If directory name end with '/**/', escape dir name to `/\**\` to inspect files under the '**/' directory.
dd2aaa8
to
c1e4009
Compare
Thank you. I rebased this. |
Thanks! |
RuboCop exits with
SystemStackError
because "stack level too deep" if the target directory has the "**" directory.If directory name end with
/**/
, escape dir name to/\**\
to inspect files under the**/
directory.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.