Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AllowMethodComparison option for Lint/MultipleComparison #8953

Conversation

koic
Copy link
Member

@koic koic commented Oct 27, 2020

Follow #8939 (comment).

This PR adds AllowMethodComparison option for Lint/MultipleComparison.

# @example AllowMethodComparison: true (default)
#   # good
#   foo if a == b.lightweight || a == b.heavyweight
#
# @example AllowMethodComparison: false
#   # bad
#   foo if a == b.lightweight || a == b.heavyweight
#
#   # good
#   foo if [b.lightweight, b.heavyweight].include?(a)

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Follow rubocop#8939 (comment).

This PR adds `AllowMethodComparison` option for `Lint/MultipleComparison`.

```ruby
# @example AllowMethodComparison: true (default)
#   # good
#   foo if a == b.lightweight || a == b.heavyweight
#
# @example AllowMethodComparison: false
#   # bad
#   foo if a == b.lightweight || a == b.heavyweight
#
#   # good
#   foo if [b.lightweight, b.heavyweight].include?(a)
```
@koic koic force-pushed the add_allow_method_comparison_to_multiple_comparison branch from b256106 to e56d84a Compare October 27, 2020 07:39
@bbatsov bbatsov merged commit 349e378 into rubocop:master Oct 27, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 27, 2020

That's exactly what I had in mind! Thanks!

@koic koic deleted the add_allow_method_comparison_to_multiple_comparison branch October 27, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants