Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Style/DocumentDynamicEvalDefinition cop #8940

Merged
merged 1 commit into from Oct 27, 2020

Conversation

fatkodima
Copy link
Contributor

This is an implementation of https://rubystyle.guide/#eval-comment-docs

@fatkodima fatkodima changed the title Add new Style/EvalWithCommentDocs cop Add new Style/EvalCommentDocs cop Oct 25, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 26, 2020

Cool idea, but we definitely need a better name for this cop. The achor in the style guide is horrible and I guess you derived the cop name from it. :-) I'm wondering about something like "DocumentDynamicEvalDefinition" or something along those lines. As usual, @rubocop-hq/rubocop-core, your ideas are most welcome! :-)

@bbatsov
Copy link
Collaborator

bbatsov commented Oct 27, 2020

Another potential name "DynamicMethodDefinitionDocumentation".

@fatkodima fatkodima changed the title Add new Style/EvalCommentDocs cop Add new Style/DocumentDynamicEvalDefinition cop Oct 27, 2020
@fatkodima
Copy link
Contributor Author

Changed the name to DocumentDynamicEvalDefinition. This variant looks nicer, imo.

@bbatsov bbatsov merged commit 0259bed into rubocop:master Oct 27, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 27, 2020

Fine by me! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants