Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept method calls for Style/MultipleComparison #8939

Merged

Conversation

koic
Copy link
Member

@koic koic commented Oct 25, 2020

This PR accepts comparisons of multiple method calls for Style/MultipleComparison to avoid unnecessary method calls.

# also good
foo if a == b.lightweight || a == b.heavyweight

This change can reduce RuboCop's own disable comment.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR accepts comparisons of multiple method calls for
`Style/MultipleComparison` to avoid unnecessary method calls.

```ruby
# also good
foo if a == b.lightweight || a == b.heavyweight
```

This change can reduce RuboCop's own disable comment.
@koic koic merged commit d459e2d into rubocop:master Oct 27, 2020
@koic koic deleted the accept_method_calls_for_style_multiple_comparison branch October 27, 2020 04:19
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 27, 2020

I'm fine with the proposed change, but I feel it would have been nice to add a configuration option controlling this behavior, as that's what we typically do.

@koic
Copy link
Member Author

koic commented Oct 27, 2020

add a configuration option controlling this behavior

Ah... sure! I will work on it soon.

koic added a commit to koic/rubocop that referenced this pull request Oct 27, 2020
Follow rubocop#8939 (comment).

This PR adds `AllowMethodComparison` option for `Lint/MultipleComparison`.

```ruby
# @example AllowMethodComparison: true (default)
#   # good
#   foo if a == b.lightweight || a == b.heavyweight
#
# @example AllowMethodComparison: false
#   # bad
#   foo if a == b.lightweight || a == b.heavyweight
#
#   # good
#   foo if [b.lightweight, b.heavyweight].include?(a)
```
bbatsov pushed a commit that referenced this pull request Oct 27, 2020
Follow #8939 (comment).

This PR adds `AllowMethodComparison` option for `Lint/MultipleComparison`.

```ruby
# @example AllowMethodComparison: true (default)
#   # good
#   foo if a == b.lightweight || a == b.heavyweight
#
# @example AllowMethodComparison: false
#   # bad
#   foo if a == b.lightweight || a == b.heavyweight
#
#   # good
#   foo if [b.lightweight, b.heavyweight].include?(a)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants