Accept method calls for Style/MultipleComparison
#8939
Merged
+19
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR accepts comparisons of multiple method calls for `Style/MultipleComparison` to avoid unnecessary method calls. ```ruby # also good foo if a == b.lightweight || a == b.heavyweight ``` This change can reduce RuboCop's own disable comment.
|
I'm fine with the proposed change, but I feel it would have been nice to add a configuration option controlling this behavior, as that's what we typically do. |
Ah... sure! I will work on it soon. |
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Oct 27, 2020
Follow rubocop#8939 (comment). This PR adds `AllowMethodComparison` option for `Lint/MultipleComparison`. ```ruby # @example AllowMethodComparison: true (default) # # good # foo if a == b.lightweight || a == b.heavyweight # # @example AllowMethodComparison: false # # bad # foo if a == b.lightweight || a == b.heavyweight # # # good # foo if [b.lightweight, b.heavyweight].include?(a) ```
bbatsov
pushed a commit
that referenced
this pull request
Oct 27, 2020
Follow #8939 (comment). This PR adds `AllowMethodComparison` option for `Lint/MultipleComparison`. ```ruby # @example AllowMethodComparison: true (default) # # good # foo if a == b.lightweight || a == b.heavyweight # # @example AllowMethodComparison: false # # bad # foo if a == b.lightweight || a == b.heavyweight # # # good # foo if [b.lightweight, b.heavyweight].include?(a) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accepts comparisons of multiple method calls for
Style/MultipleComparisonto avoid unnecessary method calls.This change can reduce RuboCop's own disable comment.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.