Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for Layout/ClassStructure #8907

Conversation

koic
Copy link
Member

@koic koic commented Oct 19, 2020

This PR fixes the following incorrect auto-correct for Layout/ClassStructure when heredoc constant is defined after public method.

% cat example.rb
class Foo
  def foo
  end

  CONSTANT = <<~EOS.freeze
    str
  EOS
end

% bundle exec rubocop --only Layout/ClassStructure -a
(snip)

% cat example.rb
class Foo
  CONSTANT = <<~EOS.freeze
  def foo
  end

    str
  EOS
end

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR fixes the following incorrect auto-correct for `Layout/ClassStructure`
when heredoc constant is defined after public method.

```console
% cat example.rb
class Foo
  def foo
  end

  CONSTANT = <<~EOS.freeze
    str
  EOS
end

% bundle exec rubocop --only Layout/ClassStructure -a
(snip)

% cat example.rb
class Foo
  CONSTANT = <<~EOS.freeze
  def foo
  end

    str
  EOS
end
```
@bbatsov bbatsov merged commit a6dd18c into rubocop:master Oct 19, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 19, 2020

Looks good! Thanks!

@koic koic deleted the fix_incorrect_autocorrect_for_layout_class_structure branch October 20, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants