Add new Style/ClassEqualityComparison cop
#8833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I agree it's a style cop. Might be a good idea to mention this in the style guide as well. |
bbatsov
reviewed
Oct 4, 2020
| | - | ||
| |=== | ||
|
|
||
| This cop enforces the use of `Object#instance_of?` instead of class comparison |
There was a problem hiding this comment.
Btw, you can use kind_of? as well. I think we have some other cop for this, so that one should honor the config of the existing cop.
There was a problem hiding this comment.
kind_of? is an alias for is_a?, which checks also superclasses. So this should be instance_of? for sure.
There was a problem hiding this comment.
I keep mixing those up. :-)
|
You'll also need to rebase. |
fatkodima
force-pushed
the
class_equality_comparison-cop
branch
from
665cf42
to
78305af
Compare
|
Rebased and added a link to style guide. |
|
Thanks! |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jun 2, 2023
…yComparison` Fixes rubocop#11914. This PR fixes an incorrect examples for `Style/ClassEqualityComparison`. The original `IgnoredMethods` (later renamed `AllowedMethods`) was introduced by rubocop#8833. OTOH, rubocop#10809 seems to have mis-documented rubocop#8833.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cop enforces the use of
Object#instance_of?instead of class comparison for equality.Ran it on 30k files and got 130 offenses. So seems useful.
Not sure if this should be in
StyleorLint(looks likeStylefor me).