Make Style/RedundantBegin aware of begin without rescue
#8822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
make_style_redundant_begin_aware_of_begin_without_rescue
branch
2 times, most recently
from
32af4ae
to
94b9d43
Compare
|
I think you should also update the examples in the cop's documentation. |
koic
force-pushed
the
make_style_redundant_begin_aware_of_begin_without_rescue
branch
from
94b9d43
to
432f3ff
Compare
|
Sure! I added the example of new target to the cop's document. |
bbatsov
approved these changes
Oct 5, 2020
This PR makes `Style/RedundantBegin` aware of `begin` without `rescue` or `ensure`. I got the inspiration below. faker-ruby/faker#1988
koic
force-pushed
the
make_style_redundant_begin_aware_of_begin_without_rescue
branch
from
432f3ff
to
7b94b88
Compare
koic
deleted the
make_style_redundant_begin_aware_of_begin_without_rescue
branch
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Oct 9, 2020
Fixes rubocop#8871. This PR fixes a false positive for `Style/RedundantBegin` when using `begin` for method argument or part of conditions. `begin` keyword may be redundant when using only one expression in `begin` of each issue case. However, since it is the unintended case for rubocop#8822, I think it can be implemented as an enhancement different from this bug fix.
bbatsov
pushed a commit
that referenced
this pull request
Oct 9, 2020
Fixes #8871. This PR fixes a false positive for `Style/RedundantBegin` when using `begin` for method argument or part of conditions. `begin` keyword may be redundant when using only one expression in `begin` of each issue case. However, since it is the unintended case for #8822, I think it can be implemented as an enhancement different from this bug fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Style/RedundantBeginaware ofbeginwithoutrescueorensure.I got the inspiration below.
faker-ruby/faker#1988
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.