Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8165] Require Parser gem 2.7.1.5 #8785

Merged
merged 2 commits into from Sep 24, 2020

Conversation

koic
Copy link
Member

@koic koic commented Sep 24, 2020

Fixes #8165 and Follows whitequark/parser#729.

Parser 2.7.1.5 includes whitequark/parser#717 and fixes #8165. And this PR updates Ruby 2.8 to Ruby 3.0.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic
Copy link
Member Author

koic commented Sep 24, 2020

This PR should be synchronized with rubocop/rubocop-ast#121 for the successful build.

@koic koic merged commit d514045 into rubocop:master Sep 24, 2020
@koic koic deleted the require_parser_gem_2_7_1_5 branch September 24, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false positive for valid pattern matching in Lint/Syntax
1 participant