Fix false positive in Style/RedundantSelf
cop with nested self
access
#8585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following false positive:
which currently returns:
This is a false positive, as
self.a
cannot be changed toa
while keeping the same semantics. Changing it toa
would effectively make the left-hand side of thisor
statement alwaysnil
, asa
has just been declared and still doesn't have a value assigned.This happens because the logic on
redundant_self.rb
does not check for nested statements (in the example,self.a
is nested node inside anor
node).This PR adds an ancestor search, starting from
self.a
, to try to find if any of its ancestors are associated with a local variable to namea
. The changes introduced work for any level of nesting.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.